All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Hugh Dickins <hughd@google.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Ondrej Zary <linux@rainbow-software.org>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Balbir Singh <balbir@in.ibm.com>
Subject: Re: Memory corruption during hibernation since 2.6.31
Date: Mon, 9 Aug 2010 09:26:46 +0200	[thread overview]
Message-ID: <20100809072646.GD1463@ucw.cz> (raw)
In-Reply-To: <20100729185529.GW16655@random.random>

Hi!

> > I've CC'ed Andrea because we were having an offline conversation about
> > whether ksmd (and his khugepaged) need to set_freezable(); and I wonder
> > if this swap bug underlies his interest, though he was mainly worrying
> > about I/O in progress.
> 
> My opinion is that with current freezer model it is needed for suspend
> to disk. The kthread_should_stop seems useless for kswapd/ksmd, but
> I'm afraid it might get useful in the future so just to stay on the
> safe side I added it to khugepaged as well, but it's contributing to
> the pollution.
> 
> I've no idea why the freezing isn't preemptive (through the scheduler,
> all these kernel threads are obviously lowlatency beasts) by default

Hibernation woulld like all  tasks frozen with no locks held - so that
write to disk does not have to care about locking.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2010-08-09  7:26 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 21:20 Memory corruption during hibernation since 2.6.31 Ondrej Zary
2010-07-28 21:34 ` Rafael J. Wysocki
2010-07-28 21:38   ` Ondrej Zary
2010-07-29  1:06     ` KAMEZAWA Hiroyuki
2010-07-29  2:51       ` KAMEZAWA Hiroyuki
2010-07-29  4:23   ` KAMEZAWA Hiroyuki
2010-07-29  5:23     ` KOSAKI Motohiro
2010-07-29  5:24       ` KAMEZAWA Hiroyuki
2010-07-29  5:30         ` KOSAKI Motohiro
2010-07-29 17:33         ` Ondrej Zary
2010-07-29 18:44         ` Hugh Dickins
2010-07-29 18:55           ` Andrea Arcangeli
2010-07-29 23:40             ` Rafael J. Wysocki
2010-07-30  4:02               ` Hugh Dickins
2010-08-09  7:26             ` Pavel Machek [this message]
2010-07-29 23:29           ` Rafael J. Wysocki
2010-07-30  3:36             ` KAMEZAWA Hiroyuki
2010-07-30  3:54             ` Hugh Dickins
2010-07-30  0:01           ` KAMEZAWA Hiroyuki
2010-07-30  4:10             ` Hugh Dickins
2010-07-30  4:14               ` KAMEZAWA Hiroyuki
2010-07-30  4:46                 ` Hugh Dickins
2010-07-30 10:43                   ` KAMEZAWA Hiroyuki
2010-07-30 18:16                     ` Hugh Dickins
2010-08-02  6:02                 ` [RFC][PATCH -mm] hibernation: freeze swap at hibernation (Was " KAMEZAWA Hiroyuki
2010-08-02 14:27                   ` Rafael J. Wysocki
2010-08-02 15:59                   ` Balbir Singh
2010-08-03  0:19                     ` KAMEZAWA Hiroyuki
2010-08-03 23:09                   ` Rafael J. Wysocki
2010-08-03 23:31                     ` KAMEZAWA Hiroyuki
2010-08-04  2:26                       ` KAMEZAWA Hiroyuki
2010-08-04  4:57                       ` [PATCH -mm] hibernation: freeze swap at hibernation v2 KAMEZAWA Hiroyuki
2010-08-04 22:18                         ` Andrew Morton
2010-08-05  0:32                           ` KAMEZAWA Hiroyuki
2010-07-30  4:18           ` Memory corruption during hibernation since 2.6.31 Balbir Singh
2010-07-30  4:32             ` Hugh Dickins
2010-07-30  6:37               ` Balbir Singh
2010-08-05 12:44         ` Ondrej Zary
2010-08-03 10:50     ` Andrea Gelmini
2010-08-03 23:36       ` KAMEZAWA Hiroyuki
2010-08-04  1:50         ` [BUGFIX][PATCH] fix corruption of hibernation caused by reusing swap at saving image KAMEZAWA Hiroyuki
2010-08-04  2:31           ` KAMEZAWA Hiroyuki
2010-08-04  2:46             ` KAMEZAWA Hiroyuki
2010-08-05 19:12               ` Hugh Dickins
2010-08-05 11:41         ` Memory corruption during hibernation since 2.6.31 Andrea Gelmini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100809072646.GD1463@ucw.cz \
    --to=pavel@ucw.cz \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@in.ibm.com \
    --cc=hughd@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.