From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Tejun Heo <htejun@gmail.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
walt <w41ter@gmail.com>,
linux-kernel@vger.kernel.org,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH wq#for-linus] workqueue: workqueue_cpu_callback() should be cpu_notifier not hotcpu_notifier
Date: Mon, 9 Aug 2010 11:46:30 +0200 [thread overview]
Message-ID: <20100809094630.GA1603@arch.tripp.de> (raw)
In-Reply-To: <4C5FCC14.6030901@gmail.com>
On Mon, Aug 09, 2010 at 11:36:20AM +0200, Tejun Heo wrote:
> Commit 6ee0578b (workqueue: mark init_workqueues as early_initcall)
> made workqueue SMP initialization depend on workqueue_cpu_callback(),
> which however was registered as hotcpu_notifier() and didn't get
> called if CONFIG_HOTPLUG_CPU is not set. This made gcwqs on non-boot
> CPUs not create their initial workers leading to boot failures. Fix
> it by making it a cpu_notifier.
>
> So, something like this. Can you please verify the fix?
This fixes the boot problem here. Thanks.
(The drm delayed enqueue problem, which I mentioned earlier still
persists.)
--
»A man who doesn't know he is in prison can never escape.«
William S. Burroughs
next prev parent reply other threads:[~2010-08-09 9:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-08 20:17 [BISECTED] Today's Linus.git hangs during boot: can't find the floppy controller walt
2010-08-09 6:37 ` Markus Trippelsdorf
2010-08-09 8:30 ` Heiko Carstens
2010-08-09 8:34 ` Heiko Carstens
2010-08-09 9:04 ` Tejun Heo
2010-08-09 9:36 ` [PATCH wq#for-linus] workqueue: workqueue_cpu_callback() should be cpu_notifier not hotcpu_notifier Tejun Heo
2010-08-09 9:46 ` Markus Trippelsdorf [this message]
2010-08-09 9:49 ` Tejun Heo
2010-08-09 9:56 ` Markus Trippelsdorf
2010-08-09 10:00 ` [PATCH wq#for-linus] drm: fix a fallout from slow-work -> wq conversion Tejun Heo
2010-08-09 10:14 ` Markus Trippelsdorf
2010-08-09 10:20 ` [PATCH] drm: fix fallouts " Tejun Heo
2010-08-09 14:00 ` walt
2018-06-19 20:32 ` Dave Airlie
2018-06-19 20:32 ` Dave Airlie
2010-08-09 13:56 ` [PATCH wq#for-linus] workqueue: workqueue_cpu_callback() should be cpu_notifier not hotcpu_notifier walt
2010-08-09 17:07 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809094630.GA1603@arch.tripp.de \
--to=markus@trippelsdorf.de \
--cc=heiko.carstens@de.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=w41ter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.