From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <david.s.daney@gmail.com>
Cc: Namhyung Kim <namhyung@gmail.com>,
linux-kernel@vger.kernel.org,
David Daney <ddaney@caviumnetworks.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: remove RELOC_HIDE on __pa_symbol
Date: Mon, 9 Aug 2010 13:21:47 +0100 [thread overview]
Message-ID: <20100809122147.GA23053@linux-mips.org> (raw)
In-Reply-To: <4C5F8ED8.90301@gmail.com>
On Sun, Aug 08, 2010 at 10:15:04PM -0700, David Daney wrote:
> On 08/08/2010 12:57 PM, Namhyung Kim wrote:
> >remove unneccessary use of RELOC_HIDE(). It does simple addition of ptr and
> >offset and in this case (offset 0) does practically nothing. It does NOT do
> >anything with linker relocation.
> >
>
> Maybe you could explain in more detail the problems you are having
> with the current definition of __pa_symbol(). I would be hesitant
> to change this bit of black magic unless there is a concrete problem
> you are trying to solve.
RELOC_HIDE was originally added by 6007b903dfe5f1d13e0c711ac2894bdd4a61b1ad
(lmo) rsp. 8431fd094d625b94d364fe393076ccef88e6ce18 (kernel.org). A
discussion can be found in lkml posting
a2ebde260608230500o3407b108hc03debb9da6e62c@mail.gmail.com> which is
archived at
http://lists.linuxcoding.com/kernel/2006-q3/msg17360.html
I felt this was dubious by the time it was added and probably should go?
Ralf
next prev parent reply other threads:[~2010-08-09 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-08 19:57 [PATCH] MIPS: remove RELOC_HIDE on __pa_symbol Namhyung Kim
2010-08-09 5:15 ` David Daney
2010-08-09 12:21 ` Ralf Baechle [this message]
2010-08-10 3:07 ` Namhyung Kim
2010-08-17 15:00 ` Ralf Baechle
2010-08-17 15:05 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809122147.GA23053@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=david.s.daney@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.