From: Mike Snitzer <snitzer@redhat.com>
To: lvm-devel@redhat.com
Subject: [RFC PATCH v2] change default alignment of pe_start to 1MB
Date: Mon, 9 Aug 2010 12:42:15 -0400 [thread overview]
Message-ID: <20100809164215.GA21397@redhat.com> (raw)
In-Reply-To: <4C602CA1.3040406@redhat.com>
On Mon, Aug 09 2010 at 12:28pm -0400,
Milan Broz <mbroz@redhat.com> wrote:
> On 08/06/2010 06:11 AM, Mike Snitzer wrote:
> > The following revised patch changes the LVM alignment detection
> > semantics to model what fdisk has elected to do:
> > - If the default value (1MB) is a multiple of the specified/detected
> > alignment then just use the default.
> > - Otherwise, use the specified/detected value.
> >
> > In practice this means we'll almost always use 1MB -- that is unless:
> > - the specified --dataalignment, MD's full stripe width, or the
> > optimal_io_size exceeds 1MB
> > - the specified/detected value is not a power-of-2
>
> patch not tested, but Ack for idea.
> (I just did independently the same for LUKS devices.)
Great. And just one point of clarification: if --dataalignment is used
then the requested alignment is used (no additional logic is allowed to
change the requested value).
Mike
prev parent reply other threads:[~2010-08-09 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 19:10 [RFC PATCH] change default alignment of pe_start to 1MB Mike Snitzer
2010-08-06 4:11 ` [RFC PATCH v2] " Mike Snitzer
2010-08-09 16:28 ` Milan Broz
2010-08-09 16:42 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809164215.GA21397@redhat.com \
--to=snitzer@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.