All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Miles Lane <miles.lane@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, oleg@redhat.com
Subject: Re: 2.6.35 - INFO: kernel/signal.c:660 invoked rcu_dereference_check() without protection!
Date: Mon, 9 Aug 2010 10:13:29 -0700	[thread overview]
Message-ID: <20100809171329.GF3026@linux.vnet.ibm.com> (raw)
In-Reply-To: <AANLkTin4RV1uw4vPqRjmM4HDEi8TT3YT5WVZ91a-8AWj@mail.gmail.com>

On Tue, Aug 03, 2010 at 11:18:07PM -0400, Miles Lane wrote:
> [ INFO: suspicious rcu_dereference_check() usage. ]
> ---------------------------------------------------
> kernel/signal.c:660 invoked rcu_dereference_check() without protection!
> 
> other info that might help us debug this:
> 
> rcu_scheduler_active = 1, debug_locks = 1
> 1 lock held by udevd/670:
>  #0:  (tasklist_lock){.+.+..}, at: [<ffffffff8104628c>] do_exit+0x252/0x671
>  stack backtrace:
>  Pid: 670, comm: udevd Not tainted 2.6.35 #15
>  Call Trace:
>  [<ffffffff8106759c>] lockdep_rcu_dereference+0x9d/0xa6
>  [<ffffffff8104f297>] check_kill_permission+0x9d/0x132
>  [<ffffffff8105010e>] group_send_sig_info+0x1a/0x3d
>  [<ffffffff81046388>] do_exit+0x34e/0x671
>  [<ffffffff81046723>] do_group_exit+0x78/0xa3
>  [<ffffffff81046760>] sys_exit_group+0x12/0x16
>  [<ffffffff81009c82>] system_call_fastpath+0x16/0x1b

Thank you again for your testing efforts!

This one is a bit odd.  exit_signals() holds either the tasklist_lock
or the ->sighand->siglock over its signal manipulations, so this is
not the code path triggering the above.  I might be missing something,
but I don't see either hrtimer_cancel() or exit_itimers() attempting
to send signals.

I am copying Oleg, as he might see something that I am missing.

							Thanx, Paul

       reply	other threads:[~2010-08-09 17:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTin4RV1uw4vPqRjmM4HDEi8TT3YT5WVZ91a-8AWj@mail.gmail.com>
2010-08-09 17:13 ` Paul E. McKenney [this message]
2010-08-10  0:31   ` 2.6.35 - INFO: kernel/signal.c:660 invoked rcu_dereference_check() without protection! Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100809171329.GF3026@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles.lane@gmail.com \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.