From: Ted Ts'o <tytso@mit.edu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] ext4 update for 2.6.36
Date: Mon, 9 Aug 2010 17:48:52 -0400 [thread overview]
Message-ID: <20100809214852.GK3635@thunk.org> (raw)
In-Reply-To: <AANLkTinJQ7DQK8_0ngHrbZugFBCgyM5ETUPhcDSmYGP6@mail.gmail.com>
On Sat, Aug 07, 2010 at 01:17:46PM -0700, Linus Torvalds wrote:
> On Thu, Aug 5, 2010 at 9:23 PM, Theodore Ts'o <tytso@mit.edu> wrote:
> >
> > Which is hopefully what you want. If you want exactly what is shown
> > below, you can also pull the "next" branch, which omits the merge, and
> > then you can deal with the merge conflict by hand. The results should
> > be the same either way.
>
> I did that just to see what it looked like.
>
> One annoyance: I now get
>
> fs/jbd2/transaction.c: In function ‘start_this_handle’:
> fs/jbd2/transaction.c:98: warning: unused variable ‘ts’
>
> due to that 'ts' thing only being used for the CONFIG_JBD2_DEBUG case.
> Please fix. I'd suggest putting that CONFIG_JBD2_DEBUG code in a
> helper function of its own, and declaring 'ts' there instead.
> Suggested patch (but with a horrible helper function name) attached.
This is what I have in the ext4 tree. I'll be sending a pull request
in a day or two with this and maybe one or two other fixups if they
arise. So far the post-integration testing I've done looks good,
though.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Ted Ts'o" <tytso@mit.edu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] ext4 update for 2.6.36
Date: Mon, 9 Aug 2010 17:48:52 -0400 [thread overview]
Message-ID: <20100809214852.GK3635@thunk.org> (raw)
In-Reply-To: <AANLkTinJQ7DQK8_0ngHrbZugFBCgyM5ETUPhcDSmYGP6@mail.gmail.com>
On Sat, Aug 07, 2010 at 01:17:46PM -0700, Linus Torvalds wrote:
> On Thu, Aug 5, 2010 at 9:23 PM, Theodore Ts'o <tytso@mit.edu> wrote:
> >
> > Which is hopefully what you want. If you want exactly what is shown
> > below, you can also pull the "next" branch, which omits the merge, and
> > then you can deal with the merge conflict by hand. The results should
> > be the same either way.
>
> I did that just to see what it looked like.
>
> One annoyance: I now get
>
> fs/jbd2/transaction.c: In function ‘start_this_handle’:
> fs/jbd2/transaction.c:98: warning: unused variable ‘ts’
>
> due to that 'ts' thing only being used for the CONFIG_JBD2_DEBUG case.
> Please fix. I'd suggest putting that CONFIG_JBD2_DEBUG code in a
> helper function of its own, and declaring 'ts' there instead.
> Suggested patch (but with a horrible helper function name) attached.
This is what I have in the ext4 tree. I'll be sending a pull request
in a day or two with this and maybe one or two other fixups if they
arise. So far the post-integration testing I've done looks good,
though.
- Ted
next prev parent reply other threads:[~2010-08-09 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 4:23 [GIT PULL] ext4 update for 2.6.36 Theodore Ts'o
2010-08-07 20:17 ` Linus Torvalds
2010-08-09 21:48 ` Ted Ts'o [this message]
2010-08-09 21:48 ` Ted Ts'o
-- strict thread matches above, loose matches on Subject: below --
2010-08-13 21:09 Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809214852.GK3635@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.