All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian@openwrt.org>
To: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: [PATCH 4/6] au1000-eth: fix bad printk usages
Date: Mon, 9 Aug 2010 22:03:40 +0200	[thread overview]
Message-ID: <201008092203.41338.florian@openwrt.org> (raw)


Use pr_(info|err) and pr_cont where required instead of calls to printk.

Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
index 9a0515d..f8f1f5e 100644
--- a/drivers/net/au1000_eth.c
+++ b/drivers/net/au1000_eth.c
@@ -732,24 +732,25 @@ static int au1000_rx(struct net_device *dev)
 			netif_rx(skb);	/* pass the packet to upper layers */
 		} else {
 			if (au1000_debug > 4) {
+				pr_err("rx_error: ");
 				if (status & RX_MISSED_FRAME)
-					printk("rx miss\n");
+					pr_cont("rx miss\n");
 				if (status & RX_WDOG_TIMER)
-					printk("rx wdog\n");
+					pr_cont("rx wdog\n");
 				if (status & RX_RUNT)
-					printk("rx runt\n");
+					pr_cont("rx runt\n");
 				if (status & RX_OVERLEN)
-					printk("rx overlen\n");
+					pr_cont("rx overlen\n");
 				if (status & RX_COLL)
-					printk("rx coll\n");
+					pr_cont("rx coll\n");
 				if (status & RX_MII_ERROR)
-					printk("rx mii error\n");
+					pr_cont("rx mii error\n");
 				if (status & RX_CRC_ERROR)
-					printk("rx crc error\n");
+					pr_cont("rx crc error\n");
 				if (status & RX_LEN_ERROR)
-					printk("rx len error\n");
+					pr_cont("rx len error\n");
 				if (status & RX_U_CNTRL_FRAME)
-					printk("rx u control frame\n");
+					pr_cont("rx u control frame\n");
 			}
 		}
 		prxd->buff_stat = (u32)(pDB->dma_addr | RX_DMA_ENABLE);
@@ -1225,7 +1226,8 @@ static int __devinit au1000_probe(struct platform_device *pdev)
 	netdev_info(dev, "Au1xx0 Ethernet found at 0x%lx, irq %d\n",
 			(unsigned long)base->start, irq);
 	if (version_printed++ == 0)
-		printk("%s version %s %s\n", DRV_NAME, DRV_VERSION, DRV_AUTHOR);
+		pr_info("%s version %s %s\n",
+					DRV_NAME, DRV_VERSION, DRV_AUTHOR);
 
 	return 0;
 



             reply	other threads:[~2010-08-09 20:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-09 20:03 Florian Fainelli [this message]
2010-08-09 22:17 ` [PATCH 4/6] au1000-eth: fix bad printk usages Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008092203.41338.florian@openwrt.org \
    --to=florian@openwrt.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.