From: Felipe Balbi <felipe.balbi@nokia.com>
To: "ext DebBarma, Tarun Kanti" <tarun.kanti@ti.com>
Cc: "Datta, Shubhrajyoti" <shubhrajyoti@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] [RFC] Remove the debug print noise
Date: Tue, 10 Aug 2010 14:52:43 +0300 [thread overview]
Message-ID: <20100810115243.GE22436@nokia.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB032401D991@dbde02.ent.ti.com>
On Tue, Aug 10, 2010 at 12:39:32PM +0200, ext DebBarma, Tarun Kanti wrote:
>> @@ -626,7 +626,7 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap,
>> if (r < 0)
>> return r;
>> if (r == 0) {
>> - dev_err(dev->dev, "controller timed out\n");
>> + dev_dbg(dev->dev, "controller timed out\n");
>
>Did you compile the code? I thought it would be as below:
>dev_dbg(&dev->dev, "controller timed out\n");
read the code more carefully. Check the definition of struct
omap_i2c_dev. It holds a pointer to a struct device already.
--
balbi
DefectiveByDesign.org
prev parent reply other threads:[~2010-08-10 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 12:47 [PATCH] [RFC] Remove the debug print noise Shubhrajyoti D
2010-08-02 12:52 ` Felipe Balbi
2010-08-02 12:59 ` Datta, Shubhrajyoti
2010-08-02 13:47 ` Nishanth Menon
2010-08-06 9:14 ` Tony Lindgren
2010-08-10 10:39 ` DebBarma, Tarun Kanti
2010-08-10 11:52 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810115243.GE22436@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
--cc=tarun.kanti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.