From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [patch 1/1]sdhci: sdhc spec 3.0 add some modification Date: Tue, 10 Aug 2010 17:32:44 +0100 Message-ID: <20100810163244.GA12837@console-pimps.org> References: <20100809101042.GA8293@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from arkanian.console-pimps.org ([212.110.184.194]:40151 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932212Ab0HJQcp (ORCPT ); Tue, 10 Aug 2010 12:32:45 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: zhangfei gao Cc: Kyungmin Park , linux-mmc@vger.kernel.org, Anton Vorontsov , Ben Dooks , Wolfram Sang On Mon, Aug 09, 2010 at 08:33:16PM +0800, zhangfei gao wrote: > > Thanks for your careful review, in our platform, we use max/min for > the max_div, so miss this modification :( > Update the patch, help review again. What do you mean? Where does max/min come from? It would definitely be best if everybody uses the same code to calculate max_div. Have you tested the max_div changes? Are you now using this patch on your platform or are you still maintaining a patch to do it a different way? If you've got a separate patch and it does this things better than the way we currently do them, get it upstream! :-)