From: Dan Williams <dan.j.williams@intel.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org
Subject: [mdadm PATCH 1/2] Incremental: return success in 'container not enough' case
Date: Tue, 10 Aug 2010 09:46:43 -0700 [thread overview]
Message-ID: <20100810164643.26691.14548.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100810164551.26691.17944.stgit@localhost.localdomain>
Commit 97b4d0e9 "Incremental: honor an 'enough' flag from external
handlers" introduced a regression in that it changed the error return
code for successful invocations.
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
Incremental.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Incremental.c b/Incremental.c
index a8a072d..e4b6196 100644
--- a/Incremental.c
+++ b/Incremental.c
@@ -264,7 +264,7 @@ int Incremental(char *devname, int verbose, int runstop,
else {
if (verbose)
fprintf(stderr, Name ": not enough devices to start the container\n");
- return 1;
+ return 0;
}
/* This is a pre-built container array, so we do something
next prev parent reply other threads:[~2010-08-10 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 16:46 [mdadm PATCH 0/2] two 3.1.3 regression fixes (incremental assembly) Dan Williams
2010-08-10 16:46 ` Dan Williams [this message]
2010-08-10 16:46 ` [mdadm PATCH 2/2] Incremental: accept '--no-degraded' as a deprecated option Dan Williams
2010-08-10 23:40 ` [mdadm PATCH 0/2] two 3.1.3 regression fixes (incremental assembly) Dan Williams
2010-08-12 1:22 ` Neil Brown
2010-08-12 1:47 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810164643.26691.14548.stgit@localhost.localdomain \
--to=dan.j.williams@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.