From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757893Ab0HJUVo (ORCPT ); Tue, 10 Aug 2010 16:21:44 -0400 Received: from mga01.intel.com ([192.55.52.88]:6430 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757865Ab0HJUVn (ORCPT ); Tue, 10 Aug 2010 16:21:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.55,349,1278313200"; d="scan'208";a="826449752" Date: Wed, 11 Aug 2010 03:53:42 +0800 From: Wu Fengguang To: Mel Gorman Cc: Naoya Horiguchi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andi Kleen , Andrew Morton Subject: Re: [PATCH 1/8] hugetlb: move definition of is_vm_hugetlb_page() to hugepage_inline.h Message-ID: <20100810195342.GA6677@localhost> References: <1275006562-18946-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1275006562-18946-2-git-send-email-n-horiguchi@ah.jp.nec.com> <20100528100350.GC9774@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100528100350.GC9774@csn.ul.ie> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +#ifndef _LINUX_HUGETLB_INLINE_H > > +#define _LINUX_HUGETLB_INLINE_H 1 > > + > > Just #define __LINUX_HUGETLB_INLINE_H is fine. No need for the 1 > > > +#ifdef CONFIG_HUGETLBFS > > + > > Should be CONFIG_HUGETLB_PAGE > > With those corrections; > > Acked-by: Mel Gorman Both fixed in Andi's tree, so Acked-by: Wu Fengguang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id E218B60080E for ; Tue, 10 Aug 2010 16:21:43 -0400 (EDT) Date: Wed, 11 Aug 2010 03:53:42 +0800 From: Wu Fengguang Subject: Re: [PATCH 1/8] hugetlb: move definition of is_vm_hugetlb_page() to hugepage_inline.h Message-ID: <20100810195342.GA6677@localhost> References: <1275006562-18946-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1275006562-18946-2-git-send-email-n-horiguchi@ah.jp.nec.com> <20100528100350.GC9774@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100528100350.GC9774@csn.ul.ie> Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: Naoya Horiguchi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andi Kleen , Andrew Morton List-ID: > > +#ifndef _LINUX_HUGETLB_INLINE_H > > +#define _LINUX_HUGETLB_INLINE_H 1 > > + > > Just #define __LINUX_HUGETLB_INLINE_H is fine. No need for the 1 > > > +#ifdef CONFIG_HUGETLBFS > > + > > Should be CONFIG_HUGETLB_PAGE > > With those corrections; > > Acked-by: Mel Gorman Both fixed in Andi's tree, so Acked-by: Wu Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org