Re: [alsa-devel] [PATCH] sound: usb: USB3 Super Speed patch

[Daniel Mack <daniel-rDUAYElUppE@public.gmane.org>]

On Wed, Aug 11, 2010 at 08:58:29AM +0200, Clemens Ladisch wrote:
> Paul Zimmerman wrote:
> > This patch adds Super Speed support to the USB drivers under sound/. It adds
> > tests for USB_SPEED_SUPER to all the places that check for the USB speed.
> 
> > +++ b/sound/usb/midi.c
> > @@ -834,7 +834,8 @@ static void snd_usbmidi_us122l_output(struct snd_usb_midi_out_endpoint *ep,
> > +++ b/sound/usb/misc/ua101.c
> > +++ b/sound/usb/usx2y/us122l.c
> > +++ b/sound/usb/usx2y/usb_stream.c
> 
> These devices do not support super speed.
> 
> > +++ b/sound/usb/pcm.c
> > -	if (snd_usb_get_speed(subs->dev) != USB_SPEED_HIGH)
> > +	if (snd_usb_get_speed(subs->dev) != USB_SPEED_HIGH &&
> > +	    snd_usb_get_speed(subs->dev) != USB_SPEED_SUPER)
> >  		/* full speed devices have fixed data packet interval */
> >  		ptmin = 1000;
> 
> In places like this, it would be better to write something like
> 	if (snd_usb_get_speed(subs->dev) == USB_SPEED_FULL)
> or
> 	if (snd_usb_get_speed(subs->dev) < USB_SPEED_HIGH)

Yep, or reconstruct the code to use switch-case statements.

Other than that, the patch looks fine to me.

Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html