From: Greg KH <gregkh@suse.de>
To: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
Cc: meego-dev@meego.com, LKML <linux-kernel@vger.kernel.org>,
qi.wang@intel.com, yong.y.wang@intel.com,
andrew.chih.howe.khor@intel.com, arjan@linux.intel.com
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35
Date: Wed, 11 Aug 2010 08:15:10 -0700 [thread overview]
Message-ID: <20100811151510.GB9180@suse.de> (raw)
In-Reply-To: <002601cb3926$edaf24d0$66f8800a@maildom.okisemi.com>
On Wed, Aug 11, 2010 at 04:29:25PM +0900, Masayuki Ohtake wrote:
> Hi Greg,
>
> > Do they all have to be ioctls? What exactly are they doing?
> I think using ioctl is common for this patch.
"Common" is not ok, right?
> Do you think that using ioctl is NOT appropriate for this patch?
Yes.
> Let me know your intension in more detail.
Please express yours. Why do you feel you need these to be ioctls?
What exactly are they doing? Where is the documentation for them all?
> > And are they 32/64bit safe?
> Only 32bit support.
That's an obvious problem that needs to be resolved, right?
thanks,
greg k-h
next prev parent reply other threads:[~2010-08-11 15:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 10:32 [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35 Masayuki Ohtak
2010-08-10 17:13 ` Greg KH
2010-08-10 17:37 ` Randy Dunlap
2010-08-11 1:20 ` Wang, Qi
2010-08-11 2:14 ` Masayuki Ohtake
2010-08-11 2:18 ` Wang, Qi
2010-08-11 2:31 ` Masayuki Ohtake
2010-08-11 5:49 ` Felipe Balbi
2010-08-11 6:31 ` Masayuki Ohtake
2010-08-11 7:29 ` Masayuki Ohtake
2010-08-11 15:15 ` Greg KH [this message]
2010-08-12 1:13 ` Wang, Qi
2010-08-12 2:00 ` Greg KH
2010-08-12 2:15 ` Wang, Qi
2010-08-17 7:12 ` Masayuki Ohtake
2010-08-17 9:06 ` [MeeGo-dev] " Richard Cochran
2010-08-17 11:25 ` Arnd Bergmann
2010-12-14 7:46 ` [MeeGo-dev][PATCH] " Tomoya MORINAGA
2010-12-14 16:21 ` Richard Cochran
2010-12-15 10:52 ` Tomoya MORINAGA
2010-08-17 13:07 ` [MeeGo-Dev][PATCH] " Greg KH
2010-08-13 8:07 ` [MeeGo-dev] " Richard Cochran
2010-08-11 9:08 ` Robert Schwebel
2010-08-11 10:45 ` [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to2.6.35 Masayuki Ohtake
2010-08-12 9:43 ` Richard Cochran
-- strict thread matches above, loose matches on Subject: below --
2010-08-11 4:34 [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35 Masayuki Ohtake
2010-08-11 4:39 ` Greg KH
2010-08-11 6:30 ` Masayuki Ohtake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100811151510.GB9180@suse.de \
--to=gregkh@suse.de \
--cc=andrew.chih.howe.khor@intel.com \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masa-korg@dsn.okisemi.com \
--cc=meego-dev@meego.com \
--cc=qi.wang@intel.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.