From: Dan Carpenter <error27@gmail.com>
To: eparis@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: re: fsnotify: pass both the vfsmount mark and inode mark
Date: Wed, 11 Aug 2010 20:51:28 +0200 [thread overview]
Message-ID: <20100811185128.GC645@bicker> (raw)
There is a NULL dereference introduced in ce8f76fb7320 "fsnotify: pass
both the vfsmount mark and inode mark"
143 static int send_to_group(struct inode *to_tell, struct vfsmount *mnt,
144 struct fsnotify_mark *inode_mark,
145 struct fsnotify_mark *vfsmount_mark,
146 __u32 mask, void *data,
147 int data_is, u32 cookie,
148 const unsigned char *file_name,
149 struct fsnotify_event **event)
150 {
151 struct fsnotify_group *group = inode_mark->group;
^^^^^^^^^^^^^^^^^^
inode_mark can be NULL.
152 __u32 inode_test_mask = (mask & ~FS_EVENT_ON_CHILD);
153 __u32 vfsmount_test_mask = (mask & ~FS_EVENT_ON_CHILD);
I'm not sure how to handle this.
regards,
dan carpenter
reply other threads:[~2010-08-11 18:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100811185128.GC645@bicker \
--to=error27@gmail.com \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.