Re: [PATCH] add SONAME to libblktapctl.so

[Olaf Hering <olaf@aepfle.de>]

On Wed, Aug 11, Ian Jackson wrote:

> > -libblktapctl.so: $(CTL_PICS)
> > -	$(CC) $(CFLAGS) -fPIC -shared -rdynamic $^ -o $@
> > +$(LIB_SHARED): $(CTL_PICS)
> > +	$(CC) $(CFLAGS) $(LDFLAGS) -fPIC  -Wl,$(SONAME_LDFLAG) -Wl,$(LIBSONAME) $(SHLIB_LDFLAGS) -rdynamic $^ -o $@
> 
> I'm not sure I understand why -fPIC appears here as a literal, rather
> than being included via some more general make variable.  And does it
> have any effect on the shared library creation link line anyway ?
> Other places that make shared libraries don't have -fPIC there.
> 
> Likewise they don't say -rdynamic.

Ian,

maybe someone has over-done things here. I'm sure libblktapctl is most
likely not different from all the other xen libraries. So I would just
drop -fPIC and -rdynamic from the options.

The gcc manual states that linking should be done with the same options
used to compile the individual objects, to get predictable results. So
if for example -fPIC wasnt there before (in CFLAGS), it wont make the
resulting lib any better.

Olaf