From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] Staging: lirc: remove unneeded variable
Date: Fri, 13 Aug 2010 13:38:40 +0000 [thread overview]
Message-ID: <20100813133840.GR645@bicker> (raw)
In-Reply-To: <20100810061120.GB18431@bicker>
On Wed, Aug 11, 2010 at 10:46:47PM -0400, Jarod Wilson wrote:
> On Tue, Aug 10, 2010 at 08:11:20AM +0200, Dan Carpenter wrote:
> > We never use control_req so I removed it.
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Leftover cruft from when lirc_imon also supported the devices now covered
> by the ir-core imon driver.
>
Speak of left over stuff, it's weird that I didn't notice this before
but gcc complains about an unitialized variable in
imon_incoming_packet().
drivers/staging/lirc/lirc_imon.c: In function ‘imon_incoming_packet’:
drivers/staging/lirc/lirc_imon.c:661: warning: ‘chunk_num’ may be used
uninitialized in this function
I don't know how to fix that, but it looks important.
regards,
dan carpenter
> Acked-by: Jarod Wilson <jarod@redhat.com>
>
>
> --
> Jarod Wilson
> jarod@redhat.com
next prev parent reply other threads:[~2010-08-13 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 6:11 [patch] Staging: lirc: remove unneeded variable Dan Carpenter
2010-08-12 2:46 ` Jarod Wilson
2010-08-13 13:38 ` Dan Carpenter [this message]
2010-08-17 21:41 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100813133840.GR645@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.