From: scameron@beardog.cce.hp.com
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] cciss: handle allocation failure
Date: Fri, 13 Aug 2010 14:48:08 +0000 [thread overview]
Message-ID: <20100813144808.GI14939@beardog.cce.hp.com> (raw)
In-Reply-To: <20100811223740.GD645@bicker>
On Thu, Aug 12, 2010 at 12:37:40AM +0200, Dan Carpenter wrote:
> If kmalloc() fails then cleanup and return failure (-1).
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 31064df..937a7c5 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -4712,6 +4712,9 @@ static int __devinit cciss_init_one(struct pci_dev *pdev,
> h->scatter_list = kmalloc(h->max_commands *
> sizeof(struct scatterlist *),
> GFP_KERNEL);
> + if (!h->scatter_list)
> + goto clean4;
> +
> for (k = 0; k < h->nr_cmds; k++) {
> h->scatter_list[k] = kmalloc(sizeof(struct scatterlist) *
> h->maxsgentries,
Ack. Thanks.
-- steve
next prev parent reply other threads:[~2010-08-13 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 22:37 [patch] cciss: handle allocation failure Dan Carpenter
2010-08-13 14:48 ` scameron [this message]
2010-08-23 10:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100813144808.GI14939@beardog.cce.hp.com \
--to=scameron@beardog.cce.hp.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.