From: Jarkko Nikula <jhnikula@gmail.com>
To: Robert Nelson <robertcnelson@gmail.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 1/3] ARM: OMAP: Beagle: revision detection
Date: Fri, 13 Aug 2010 15:44:54 +0300 [thread overview]
Message-ID: <20100813154454.aca470ee.jhnikula@gmail.com> (raw)
In-Reply-To: <1281702070-10525-1-git-send-email-robertcnelson@gmail.com>
On Fri, 13 Aug 2010 07:21:08 -0500
Robert Nelson <robertcnelson@gmail.com> wrote:
> + /* Older U-Boot's such as 2009.01-dirty don't have the pins
> + * muxed correctly to use the generic gpio_direction_input();
> + */
> + omap_mux_init_gpio(171, OMAP_PIN_INPUT_PULLUP);
> + omap_mux_init_gpio(172, OMAP_PIN_INPUT_PULLUP);
> + omap_mux_init_gpio(173, OMAP_PIN_INPUT_PULLUP);
> +
Comment (and code) is wrong: gpio_direction_input is still required to
setup pin direction and letting the gpiolib to setup internal data
structures properly. I.e. both mux setup and gpio_direction_input are
required.
--
Jarkko
next prev parent reply other threads:[~2010-08-13 12:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 12:21 [PATCH v3 1/3] ARM: OMAP: Beagle: revision detection Robert Nelson
2010-08-13 12:21 ` [PATCH v3 2/3] ARM: OMAP: Beagle: only Cx boards use pin 23 for write protect Robert Nelson
2010-08-13 12:21 ` [PATCH v3 3/3] ARM: OMAP: Beagle: no gpio_wp pin connection on xM Robert Nelson
2010-08-13 12:44 ` Jarkko Nikula [this message]
2010-08-13 12:51 ` [PATCH v3 1/3] ARM: OMAP: Beagle: revision detection Robert Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100813154454.aca470ee.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.