All of lore.kernel.org
 help / color / mirror / Atom feed
From: Enrico Weigelt <weigelt@metux.de>
To: git@vger.kernel.org
Subject: Re: BUG! missing .idx causes .pack to be removed
Date: Fri, 13 Aug 2010 18:02:21 +0200	[thread overview]
Message-ID: <20100813160221.GA10974@nibiru.local> (raw)
In-Reply-To: <4C5BB64A.4070601@lsrfire.ath.cx>

* René Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:
> > IIRC, a .pack file is useless without its corresponding .idx file. So
> > the removal of a .pack file makes sense here - to me, at least.
> 
> git-index-pack can rebuild the index for a pack file.  Not sure if it
> should be done automagically, but the file is not completely useless.

ACK. packfiles are completely self-contained - the index files are
only used for lookup and can be created any time (IMHO that's also
done automatically on remote transfers). So removing a packfile,
just because the index is missing, causes an serious data loss.
That's what I'd consider a critical bug!

The correct solution would be either recreating the index
automatically or at least spit out an big-fat warning.


cu
-- 
----------------------------------------------------------------------
 Enrico Weigelt, metux IT service -- http://www.metux.de/

 phone:  +49 36207 519931  email: weigelt@metux.de
 mobile: +49 151 27565287  icq:   210169427         skype: nekrad666
----------------------------------------------------------------------
 Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme
----------------------------------------------------------------------

      reply	other threads:[~2010-08-13 16:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-05 17:01 BUG! missing .idx causes .pack to be removed Enrico Weigelt
2010-08-06  3:24 ` Tay Ray Chuan
2010-08-06  7:14   ` René Scharfe
2010-08-13 16:02     ` Enrico Weigelt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100813160221.GA10974@nibiru.local \
    --to=weigelt@metux.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.