diff for duplicates of <20100814090619.GY645@bicker> diff --git a/a/1.txt b/N1/1.txt index 4b731ad..be7f71c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,7 +7,7 @@ NULL dereference of "ehci". This bug was introduced in: 796bcae7361c I modified the few lines in front a little so that my code didn't obscure the return success code path. -Signed-off-by: Dan Carpenter <error27@gmail.com> +Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- I don't have a cross compile environment set up so I haven't compiled this code. Sorry for that. @@ -20,7 +20,7 @@ index 335ee69..ba52be4 100644 } rv = usb_add_hcd(hcd, irq, 0); -- if (rv = 0) +- if (rv == 0) - return 0; + if (rv) + goto err_ehci; @@ -35,8 +35,3 @@ index 335ee69..ba52be4 100644 irq_dispose_mapping(irq); err_irq: release_mem_region(hcd->rsrc_start, hcd->rsrc_len); -- -- if (ehci->has_amcc_usb23) -- iounmap(ehci->ohci_hcctrl_reg); - err_rmr: - usb_put_hcd(hcd); diff --git a/a/content_digest b/N1/content_digest index 6e0cf7a..a5f285d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ - "From\0Dan Carpenter <error27@gmail.com>\0" + "From\0Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" "Subject\0[patch] ehci-ppc-of: problems in unwind\0" - "Date\0Sat, 14 Aug 2010 09:06:19 +0000\0" + "Date\0Sat, 14 Aug 2010 11:06:19 +0200\0" "To\0David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>\0" "Cc\0Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>" Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> @@ -21,7 +21,7 @@ "I modified the few lines in front a little so that my code didn't\n" "obscure the return success code path.\n" "\n" - "Signed-off-by: Dan Carpenter <error27@gmail.com>\n" + "Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\n" "---\n" "I don't have a cross compile environment set up so I haven't compiled\n" "this code. Sorry for that.\n" @@ -34,7 +34,7 @@ " \t}\n" " \n" " \trv = usb_add_hcd(hcd, irq, 0);\n" - "-\tif (rv = 0)\n" + "-\tif (rv == 0)\n" "-\t\treturn 0;\n" "+\tif (rv)\n" "+\t\tgoto err_ehci;\n" @@ -48,11 +48,6 @@ " err_ioremap:\n" " \tirq_dispose_mapping(irq);\n" " err_irq:\n" - " \trelease_mem_region(hcd->rsrc_start, hcd->rsrc_len);\n" - "-\n" - "-\tif (ehci->has_amcc_usb23)\n" - "-\t\tiounmap(ehci->ohci_hcctrl_reg);\n" - " err_rmr:\n" - " \tusb_put_hcd(hcd);" + " \trelease_mem_region(hcd->rsrc_start, hcd->rsrc_len);" -1f5a0f91df0cb8747109794394f2c1147337249e46c90848a2f5bb77d3df0922 +4d094c58e76748b05e988a61a5d75fc9c753664ea23bade410ce184b9bf67b3f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.