All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] ls-tree: show size of trees with -l
Date: Sat, 14 Aug 2010 16:40:11 +0200	[thread overview]
Message-ID: <201008141640.14745.jnareb@gmail.com> (raw)
In-Reply-To: <1281730823-10797-1-git-send-email-pclouds@gmail.com>

On Fri, 13 Apr 2010, Nguyễn Thái Ngọc Duy wrote:

> In commit a5bbda8 (Add an option to git-ls-tree to display also the
> size of blob), Jakub said that size of non-blob entries had no
> meaning therefore dashes were printed instead.

I wrote that?

> 
> I would say tree size, along with blob size, helps estimate bandwidth
> needed to transfer a single commit, for example. Of course it's not
> completely accurate as all objects will be compressed. But it gives a
> rough figure to compare.
> 
> Pack v4 has not come yet (and it's been three years, I truely hope it
> will come next year). When it comes, I will gladly send a revert patch
> of this one if it proves too expensive to compute tree size.
> 
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---

Actually "git ls-tree -l <tree-ish>" doesn't show size of tree objects
because packv4 was to be ready soon, and in packv4 trees would be stored
decomposed, so getting size of tree object (e.g. using git-cat-file) is
would be costly because git would have to re-generate tree object just 
to get its size (if it is in packfile).

But we don't have packv4 yet, even though it is 3 years since a5bbda8.
It looks like packv4 development moves with the speed of Perl 6 
development.  But if Rakudo * (Perl 6 implementation) could have get 
released (even if it is developers release), then there is hope for 
packv4 yet... I hope...

-- 
Jakub Narebski
Poland

      reply	other threads:[~2010-08-14 14:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13 20:20 [PATCH] ls-tree: show size of trees with -l Nguyễn Thái Ngọc Duy
2010-08-14 14:40 ` Jakub Narebski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008141640.14745.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.