From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [patch v2] sound/usb/format: silence uninitialized variable warnings Date: Sat, 14 Aug 2010 19:38:24 +0200 Message-ID: <20100814173824.GX17833@buzzloop.caiaq.de> References: <20100814085846.GV645@bicker> <20100814172953.GA645@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from buzzloop.caiaq.de (buzzloop.caiaq.de [212.112.241.133]) by alsa0.perex.cz (Postfix) with ESMTP id C2E9A1037F2 for ; Sat, 14 Aug 2010 19:38:28 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20100814172953.GA645@bicker> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Dan Carpenter Cc: Stephen Rothwell , alsa-devel@alsa-project.org, Takashi Iwai , Clemens Ladisch , kernel-janitors@vger.kernel.org List-Id: alsa-devel@alsa-project.org T24gU2F0LCBBdWcgMTQsIDIwMTAgYXQgMDc6Mjk6NTNQTSArMDIwMCwgRGFuIENhcnBlbnRlciB3 cm90ZToKPiBHY2MgY29tcGxhaW5zIHRoYXQgcmV0IG1pZ2h0IGJlIHVzZWQgdW5pbml0aWFsaXpl ZDoKPiAKPiBzb3VuZC91c2IvZm9ybWF0LmM6IEluIGZ1bmN0aW9uIOKAmHNuZF91c2JfcGFyc2Vf YXVkaW9fZm9ybWF04oCZOgo+IHNvdW5kL3VzYi9mb3JtYXQuYzozNTQ6IHdhcm5pbmc6IOKAmHJl dOKAmSBtYXkgYmUgdXNlZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVuY3Rpb24KPiBzb3VuZC91 c2IvZm9ybWF0LmM6MzU0OiBub3RlOiDigJhyZXTigJkgd2FzIGRlY2xhcmVkIGhlcmUKPiBzb3Vu ZC91c2IvZm9ybWF0LmM6NDE0OiB3YXJuaW5nOiDigJhyZXTigJkgbWF5IGJlIHVzZWQgdW5pbml0 aWFsaXplZCBpbiB0aGlzIGZ1bmN0aW9uCj4gc291bmQvdXNiL2Zvcm1hdC5jOjQxNDogbm90ZTog 4oCYcmV04oCZIHdhcyBkZWNsYXJlZCBoZXJlCj4gCj4gSSBzdXBwb3NlIGl0IGNvdWxkIGJlIHVu aW5pdGlhbGl6ZWQgaWYgdGhlcmUgaXMgZXZlciBhIFVBQ19WRVJTSU9OXzMKPiByZWxlYXNlZC4g QW55d2F5IHRoaXMgcGF0Y2ggaXMgd29ydGh3aGlsZSBpZiBvbmx5IHRvIHNpbGVuY2UgdGhlIGdj Ywo+IHdhcm5pbmcuCj4gCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZXJyb3IyN0Bn bWFpbC5jb20+CgpZZXMsIHN1Y2ggYSBjaGVjayBjYW4ndCBoYXJtLiBZb3UgY2FuIGhhdmUgbXkg CgogIEFja2VkLWJ5OiBEYW5pZWwgTWFjayA8ZGFuaWVsQGNhaWFxLmRlPgoKaWYgeW91IHdhbnQg OikKCgpUaGFua3MsCkRhbmllbAoKPiAtLS0KPiBWMjogVG90YWxseSBkaWZmZXJlbnQuICBBZGRl ZCBwcmludGsoKXMKPiAKPiBkaWZmIC0tZ2l0IGEvc291bmQvdXNiL2Zvcm1hdC5jIGIvc291bmQv dXNiL2Zvcm1hdC5jCj4gaW5kZXggNDM4N2Y1NC4uM2ExMzc1NCAxMDA2NDQKPiAtLS0gYS9zb3Vu ZC91c2IvZm9ybWF0LmMKPiArKysgYi9zb3VuZC91c2IvZm9ybWF0LmMKPiBAQCAtMzkyLDYgKzM5 MiwxMCBAQCBzdGF0aWMgaW50IHBhcnNlX2F1ZGlvX2Zvcm1hdF9pKHN0cnVjdCBzbmRfdXNiX2F1 ZGlvICpjaGlwLAo+ICAJCS8qIGZwLT5jaGFubmVscyBpcyBhbHJlYWR5IHNldCBpbiB0aGlzIGNh c2UgKi8KPiAgCQlyZXQgPSBwYXJzZV9hdWRpb19mb3JtYXRfcmF0ZXNfdjIoY2hpcCwgZnApOwo+ ICAJCWJyZWFrOwo+ICsJZGVmYXVsdDoKPiArCQlzbmRfcHJpbnRrKEtFUk5fRVJSICIlZDoldTol ZCA6IGludmFsaWQgcHJvdG9jb2wgdmVyc2lvbiAlZFxuIiwKPiArCQkJICAgY2hpcC0+ZGV2LT5k ZXZudW0sIGZwLT5pZmFjZSwgZnAtPmFsdHNldHRpbmcsIHByb3RvY29sKTsKPiArCQlyZXR1cm4g LUVJTlZBTDsKPiAgCX0KPiAgCj4gIAlpZiAoZnAtPmNoYW5uZWxzIDwgMSkgewo+IEBAIC00NTIs NiArNDU2LDEwIEBAIHN0YXRpYyBpbnQgcGFyc2VfYXVkaW9fZm9ybWF0X2lpKHN0cnVjdCBzbmRf dXNiX2F1ZGlvICpjaGlwLAo+ICAJCXJldCA9IHBhcnNlX2F1ZGlvX2Zvcm1hdF9yYXRlc192Mihj aGlwLCBmcCk7Cj4gIAkJYnJlYWs7Cj4gIAl9Cj4gKwlkZWZhdWx0Ogo+ICsJCXNuZF9wcmludGso S0VSTl9FUlIgIiVkOiV1OiVkIDogaW52YWxpZCBwcm90b2NvbCB2ZXJzaW9uICVkXG4iLAo+ICsJ CQkgICBjaGlwLT5kZXYtPmRldm51bSwgZnAtPmlmYWNlLCBmcC0+YWx0c2V0dGluZywgcHJvdG9j b2wpOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICAJfQo+ICAKPiAgCXJldHVybiByZXQ7Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFp bGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNh LXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Date: Sat, 14 Aug 2010 17:38:24 +0000 Subject: Re: [patch v2] sound/usb/format: silence uninitialized variable Message-Id: <20100814173824.GX17833@buzzloop.caiaq.de> List-Id: References: <20100814085846.GV645@bicker> <20100814172953.GA645@bicker> In-Reply-To: <20100814172953.GA645@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter Cc: Stephen Rothwell , alsa-devel@alsa-project.org, Takashi Iwai , Clemens Ladisch , kernel-janitors@vger.kernel.org On Sat, Aug 14, 2010 at 07:29:53PM +0200, Dan Carpenter wrote: > Gcc complains that ret might be used uninitialized: > > sound/usb/format.c: In function ‘snd_usb_parse_audio_format’: > sound/usb/format.c:354: warning: ‘ret’ may be used uninitialized in this function > sound/usb/format.c:354: note: ‘ret’ was declared here > sound/usb/format.c:414: warning: ‘ret’ may be used uninitialized in this function > sound/usb/format.c:414: note: ‘ret’ was declared here > > I suppose it could be uninitialized if there is ever a UAC_VERSION_3 > released. Anyway this patch is worthwhile if only to silence the gcc > warning. > > Signed-off-by: Dan Carpenter Yes, such a check can't harm. You can have my Acked-by: Daniel Mack if you want :) Thanks, Daniel > --- > V2: Totally different. Added printk()s > > diff --git a/sound/usb/format.c b/sound/usb/format.c > index 4387f54..3a13754 100644 > --- a/sound/usb/format.c > +++ b/sound/usb/format.c > @@ -392,6 +392,10 @@ static int parse_audio_format_i(struct snd_usb_audio *chip, > /* fp->channels is already set in this case */ > ret = parse_audio_format_rates_v2(chip, fp); > break; > + default: > + snd_printk(KERN_ERR "%d:%u:%d : invalid protocol version %d\n", > + chip->dev->devnum, fp->iface, fp->altsetting, protocol); > + return -EINVAL; > } > > if (fp->channels < 1) { > @@ -452,6 +456,10 @@ static int parse_audio_format_ii(struct snd_usb_audio *chip, > ret = parse_audio_format_rates_v2(chip, fp); > break; > } > + default: > + snd_printk(KERN_ERR "%d:%u:%d : invalid protocol version %d\n", > + chip->dev->devnum, fp->iface, fp->altsetting, protocol); > + return -EINVAL; > } > > return ret;