From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Linus Walleij <linus.walleij@stericsson.com>,
Mattias Wallin <mattias.wallin@stericsson.com>
Subject: Re: [PATCH] regulator: ab3100 - fix the logic to remove already registered regulators in error path
Date: Sun, 15 Aug 2010 14:46:54 +0100 [thread overview]
Message-ID: <20100815134654.GA26969@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1281792661.2718.4.camel@phoenix>
On Sat, Aug 14, 2010 at 09:31:01PM +0800, Axel Lin wrote:
> In current implementation, ab3100_regulators[0].rdev is not unregistered if
> the error happen at i > 0.
>
> This patch fixes the resource leak and also improves the readability.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2010-08-15 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-14 13:31 [PATCH] regulator: ab3100 - fix the logic to remove already registered regulators in error path Axel Lin
2010-08-15 12:01 ` Linus Walleij
2010-08-15 13:46 ` Mark Brown [this message]
2010-08-18 13:29 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100815134654.GA26969@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=mattias.wallin@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.