From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Suresh Siddha <suresh.b.siddha@intel.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] x86: Don't write io_apic ID if it is not changed
Date: Mon, 16 Aug 2010 13:06:45 +0400 [thread overview]
Message-ID: <20100816090645.GA5805@lenovo> (raw)
In-Reply-To: <20100815083057.GB5629@lenovo>
On Sun, Aug 15, 2010 at 12:30:57PM +0400, Cyrill Gorcunov wrote:
> On Sun, Aug 15, 2010 at 12:24:46PM +0400, Cyrill Gorcunov wrote:
> ...
> > As far as I see, this was done by a purpose in former code. Consider the
> > situation when mp_ioapics[apic_id].apicid >= get_physical_broadcast().
> > By code flow (io_apic.c:2099) this set
> >
> > if (mp_ioapics[apic_id].apicid >= get_physical_broadcast()) {
> > printk(KERN_ERR "BIOS bug, IO-APIC#%d ID is %d in the MPC table!...\n",
> > apic_id, mp_ioapics[apic_id].apicid);
> > printk(KERN_ERR "... fixing up to %d. (tell your hw vendor)\n",
> > reg_00.bits.ID);
> > ---> mp_ioapics[apic_id].apicid = reg_00.bits.ID;
> > }
> >
> > So with your patch we always hit "continue" without real changing of ID which
> > is not correct.
> >
> > But perhaps I miss something?
> >
> > -- Cyrill
>
> False alarm Yinghai, of course there is no need to write same value back,
> sorry for noise.
>
> -- Cyrill
Thinking a bit more I guess there might be a sence to write io-apic id
unconditionally, io-apic id is not latched on reset but set to 0 (at least
for old apics) so if we hit id match -- this will be once, but the same
time we will have additional if() for every cycle iteration, not sure
it worth it. Right?
-- Cyrill
next prev parent reply other threads:[~2010-08-16 9:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-14 20:38 [PATCH] x86: Don't write io_apic ID if it is not changed Yinghai Lu
2010-08-15 8:24 ` Cyrill Gorcunov
2010-08-15 8:30 ` Cyrill Gorcunov
2010-08-16 9:06 ` Cyrill Gorcunov [this message]
2010-08-15 15:55 ` Eric W. Biederman
2010-08-16 7:28 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816090645.GA5805@lenovo \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.