From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Mohammed Gamal <m.gamal005@gmail.com>,
kvm@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [RFC PATCH v3 0/4] Real mode interrupt injection
Date: Mon, 16 Aug 2010 17:29:23 +0300 [thread overview]
Message-ID: <20100816142923.GA21482@redhat.com> (raw)
In-Reply-To: <4C694821.1020108@redhat.com>
On Mon, Aug 16, 2010 at 05:16:01PM +0300, Avi Kivity wrote:
> On 08/16/2010 04:28 PM, Mohammed Gamal wrote:
> >
> >>I debugged this for a bit - emulate_int_real() is completely broken.
> >> emulate_push() doesn't push anything, it only schedules a push; running
> >>these back-to-back will result in only the last push to be executed.
> >>
> >So we need write back the decode cache after each push. Or let
> >emulate_push() change the emulation context directly. Please CMIIW
>
> I wrote a push_std() that uses ->write_std() instead of
> ->write_emulated() and can be used back-to-back. Long term we'll
> need a write queue but for the short term this will do.
>
Why not just call writeback() after the emulate_push()? emulate_pusha()
does it.
--
Gleb.
next prev parent reply other threads:[~2010-08-16 14:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-15 21:46 [RFC PATCH v3 0/4] Real mode interrupt injection Mohammed Gamal
2010-08-15 21:47 ` [RFC PATCH v3 1/4] x86 emulator: Expose emulate_int_real() Mohammed Gamal
2010-08-15 21:47 ` [RFC PATCH v3 2/4] x86: Separate emulation context initialization in a separate function Mohammed Gamal
2010-08-15 21:47 ` [RFC PATCH v3 3/4] x86: Add kvm_inject_realmode_interrupt() wrapper Mohammed Gamal
2010-08-15 21:47 ` [RFC PATCH v3 4/4] VMX: Emulated real mode interrupt injection Mohammed Gamal
2010-08-15 23:37 ` [RFC PATCH v3 0/4] Real " Mohammed Gamal
2010-08-16 8:51 ` Avi Kivity
2010-08-16 13:19 ` Avi Kivity
2010-08-16 13:28 ` Mohammed Gamal
2010-08-16 14:16 ` Avi Kivity
2010-08-16 14:29 ` Gleb Natapov [this message]
2010-08-16 14:47 ` Avi Kivity
2010-08-16 15:23 ` Mohammed Gamal
2010-08-16 15:31 ` Gleb Natapov
2010-08-16 15:33 ` Avi Kivity
2010-08-16 15:43 ` Mohammed Gamal
2010-08-16 10:14 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816142923.GA21482@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.