All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Kusanagi Kouichi <slash@ac.auone-net.jp>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix build error on read only source.
Date: Mon, 16 Aug 2010 12:24:10 -0300	[thread overview]
Message-ID: <20100816152410.GA13095@ghostprotocols.net> (raw)
In-Reply-To: <20100816124017.BE24D6AC03A@msa102.auone-net.jp>

Em Mon, Aug 16, 2010 at 09:40:13PM +0900, Kusanagi Kouichi escreveu:
... 
> diff --git a/tools/perf/feature-tests.mak b/tools/perf/feature-tests.mak
> @@ -113,7 +113,5 @@ endef
>  # try-cc
>  # Usage: option = $(call try-cc, source-to-build, cc-options)
>  try-cc = $(shell sh -c						  \
> -	'TMP="$(TMPOUT).$$$$";			 		  \
> -	 echo "$(1)" |						  \
> -	 $(CC) -x c - $(2) -o "$$TMP" > /dev/null 2>&1 && echo y; \
> -	 rm -f "$$TMP"')
> +	'echo "$(1)" |						  \
> +	 $(CC) -x c - $(2) -o /dev/null > /dev/null 2>&1 && echo y')

Please read:

 f9af3a4c1f59753bdd5a49e3a34263005f96972e
 8b2c551f9635bf1c5c2d38de300137998915478f
 1703f2c321a8a531c393e137a82602e16c6061cb

To see why we can't use '-o /dev/null' like that.

- Arnaldo

  reply	other threads:[~2010-08-16 15:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-16 12:40 [PATCH] perf tools: Fix build error on read only source Kusanagi Kouichi
2010-08-16 15:24 ` Arnaldo Carvalho de Melo [this message]
2010-08-17 12:57   ` Kusanagi Kouichi
2010-08-17 14:08   ` Kusanagi Kouichi
2010-08-17 14:17     ` Arnaldo Carvalho de Melo
2010-08-19 11:22     ` [tip:perf/urgent] " tip-bot for Kusanagi Kouichi
  -- strict thread matches above, loose matches on Subject: below --
2010-08-17 18:18 [PATCH] " Arnaldo Carvalho de Melo
2010-08-18 12:37 ` Kusanagi Kouichi
2010-08-18 12:40   ` Peter Zijlstra
2010-08-18 14:16     ` Arnaldo Carvalho de Melo
2010-08-18 14:27       ` Peter Zijlstra
2010-08-18 16:56         ` Arnaldo Carvalho de Melo
2010-08-18 17:01           ` Arnaldo Carvalho de Melo
2010-08-18 19:09             ` Arnaldo Carvalho de Melo
2010-08-19  9:02               ` Bernd Petrovitsch
2010-08-18 14:14   ` Arnaldo Carvalho de Melo
2010-08-18 15:25     ` Bernd Petrovitsch
2010-08-18 17:19       ` Arnaldo Carvalho de Melo
2010-08-19 10:31         ` Bernd Petrovitsch
2010-08-19 14:13           ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100816152410.GA13095@ghostprotocols.net \
    --to=acme@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=slash@ac.auone-net.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.