Re: [PATCH v1 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers

[Randy Dunlap <randy.dunlap@oracle.com>]

On Mon, 16 Aug 2010 15:17:05 -0700 Vu Pham wrote:

>  {hm, no text to reply to;  oh, the patch is an attachment; please don't do that}


(copy-paste here:)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 158284f..3573cee 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -687,6 +687,28 @@ config FCOE_FNIC
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called fnic.
 
+config MLX4_FC
+	tristate "Mellanox FC module"
+	depends on MLX4_EN

	depends on 
+	select LIBFC
+	select LIBFCOE
+	help
+	  Fibre Channel over Ethernet/Infiniband module
+
+	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs
+	  The module will be called mlx4_fc

End both lines above with periods (".").

+
+config MLX4_FCOIB
+	tristate "Mellanox FCoIB discovery module"
+	depends on INFINIBAND
+	select MLX4_FC
+	help
+	  Fibre Channel over Infiniband discovery module
+
+	  The module FIP-alike to discover BridgeX gateways in the
+	  Infiniband fabric

end sentence with ".".

What does "FIP-alike" mean?  and fix grammar:

	  This module attempts to discover BridgeX gateways in the
	  Infiniband fabric.
?


+	  The module will be called mlx4_fc
+

end sentence with ".".


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***