All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Bowler <nbowler@elliptictech.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Shaohua Li <shaohua.li@intel.com>,
	Trond.Myklebust@netapp.com, rjw@sisk.pl,
	linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: nfs regression 2.6.35+
Date: Mon, 16 Aug 2010 14:17:51 -0400	[thread overview]
Message-ID: <20100816181751.GA2439@elliptictech.com> (raw)
In-Reply-To: <s5hfwyelu28.wl%tiwai@suse.de>

On 2010-08-16 12:40 +0200, Takashi Iwai wrote:
> At Mon, 16 Aug 2010 12:09:12 +0200, Takashi Iwai wrote:
> > This hits me, too.  Reverting it cures the problem.
> > (BTW, the correct commit id of the affecting patch is
> >  af7fa16506bf9b6323e862a61e14c20555152bb3
> >  "NFS: Fix up the fsync code")
> > 
> > Reproduced on 2.6.36-rc1.
> > 
> > So, fsync() returns 1 wrongly.

Apparently this breaks NFS file locks as well:  

  fetchmail: starting fetchmail 6.3.17 daemon
  /home/nbowler/.fetchmail.pid: Bad file descriptor
  fetchmail: lock creation failed.

> How about a band-aid fix below?
[...]
> Subject: [PATCH] NFS: fix fsync return code

and this fixes all the problems for me.

-- 
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)

  parent reply	other threads:[~2010-08-16 18:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-16  7:06 nfs regression 2.6.35+ Shaohua Li
2010-08-16 10:09 ` Takashi Iwai
2010-08-16 10:40   ` Takashi Iwai
2010-08-16 16:35     ` Bill Davidsen
2010-08-16 16:35       ` Bill Davidsen
2010-08-16 18:17     ` Nick Bowler [this message]
2010-08-16 22:47 ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100816181751.GA2439@elliptictech.com \
    --to=nbowler@elliptictech.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=shaohua.li@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.