From: "Grégoire Baron" <baronchon@n7mm.org>
To: jamal <hadi@cyberus.ca>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net/sched: add ACT_CSUM action to update packets checksums
Date: Tue, 17 Aug 2010 01:02:17 +0200 [thread overview]
Message-ID: <20100816230217.GA24125@n7mm.org> (raw)
In-Reply-To: <1281996019.5765.6.camel@bigi>
> Excellent work! Ive always wanted to do this albeit slightly
> differently.
Thanks!
> I think it would be nice to factor a lot of the code repeated
> everywhere into some boilerplate function that gets invoked by all;
> users.
You're rigth. I will correct that, maybe using a macro which is
specialised to get the protocol structure ...
However, this macro could call a 'goto' instruction. Is it really a good
idea? Tell me. Are you sure a function is appropriate?
Regards,
Grégoire
next prev parent reply other threads:[~2010-08-16 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 21:15 [PATCH] net/sched: add ACT_CSUM action to update packets checksums Grégoire Baron
2010-08-16 22:00 ` jamal
2010-08-16 23:02 ` Grégoire Baron [this message]
2010-08-17 12:36 ` jamal
2010-08-18 0:04 ` Grégoire Baron
2010-08-18 10:42 ` jamal
2010-08-17 5:19 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816230217.GA24125@n7mm.org \
--to=baronchon@n7mm.org \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.