All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Mario Bachmann <mbachman@stud.uni-frankfurt.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] Re: xfsdump-3.0.4 problems
Date: Wed, 18 Aug 2010 06:10:36 -0400	[thread overview]
Message-ID: <20100818101036.GA14467@infradead.org> (raw)
In-Reply-To: <20100817114550.GQ10429@dastard>

> xfs: fix untrusted inode number lookup
> 
> From: Dave Chinner <dchinner@redhat.com>
> 
> Commit 7124fe0a5b619d65b739477b3b55a20bf805b06d ("xfs: validate untrusted inode
> numbers during lookup") changes the inode lookup code to do btree lookups for
> untrusted inode numbers. This change made an invalid assumption about the
> alignment of inodes and hence incorrectly calculated the first inode in the
> cluster. As a result, some inode numbers were being incorrectly considered
> invalid when they were actually valid.
> 
> The issue was not picked up by the xfstests suite because it always runs fsr
> and dump (the two utilities that utilise the bulkstat interface) on cache hot
> inodes and hence the lookup code in the cold cache path was not sufficiently
> exercised to uncover this intermittent problem.
> 
> Fix the issue by relaxing the btree lookup criteria and then checking if the
> record returned contains the inode number we are lookup for. If it we get an
> incorrect record, then the inode number is invalid.

Looks good and fixes the dump issues I've seen in xfstests.


Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2010-08-18 10:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-16 16:22 xfsdump-3.0.4 problems Mario Bachmann
2010-08-16 22:30 ` Dave Chinner
2010-08-17  6:32   ` Mario Bachmann
2010-08-17  7:13     ` Dave Chinner
2010-08-17  7:53       ` Mario Bachmann
2010-08-17  9:05         ` Dave Chinner
2010-08-17 11:45           ` [PATCH] " Dave Chinner
2010-08-17 15:47             ` Mario Bachmann
2010-08-18 10:10             ` Christoph Hellwig [this message]
2010-08-27 11:18             ` Iustin Pop
2010-08-27 11:40               ` Dave Chinner
2010-09-24  9:53                 ` Mario Bachmann
2010-10-03  6:20                   ` Christoph Hellwig
2010-08-17  9:03       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100818101036.GA14467@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=mbachman@stud.uni-frankfurt.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.