From: Andy Whitcroft <apw@canonical.com>
To: Joe Perches <joe@perches.com>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] scripts/checkpatch.pl: Add additional attribute #defines
Date: Wed, 18 Aug 2010 12:30:23 +0100 [thread overview]
Message-ID: <20100818113023.GR6193@shadowen.org> (raw)
In-Reply-To: <1281547748.3976.41.camel@Joe-Laptop.home>
On Wed, Aug 11, 2010 at 10:29:08AM -0700, Joe Perches wrote:
> On Wed, 2010-08-11 at 12:35 -0400, Dave Jones wrote:
> > I just got this from a patch I merged..
> >
> > ERROR: need consistent spacing around '*' (ctx:WxV)
> > #121: FILE: arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c:113:
> > +static struct pcc_cpu __percpu *pcc_cpu_info;
> > ^
> > which doesn't seem right.
>
> Perhaps these need to be added to checkpatch.
>
> Signed-off-by: Joe Perches <joe@perches.com>
This one looks sane to me, I've pulled this into my tree. The version
at the URL below should contain it for testing:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
-apw
prev parent reply other threads:[~2010-08-18 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 16:35 checkpatch false positive Dave Jones
2010-08-11 17:29 ` [PATCH] scripts/checkpatch.pl: Add additional attribute #defines Joe Perches
2010-08-18 11:30 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818113023.GR6193@shadowen.org \
--to=apw@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.