From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: COLIBRI PXA320: fix UCB1400 irq autoprobing
Date: Wed, 18 Aug 2010 13:50:08 +0200 [thread overview]
Message-ID: <20100818115008.GI17833@buzzloop.caiaq.de> (raw)
In-Reply-To: <201008112326.20098.marek.vasut@gmail.com>
On Wed, Aug 11, 2010 at 11:26:20PM +0200, Marek Vasut wrote:
> Dne St 11. srpna 2010 16:33:45 Daniel Mack napsal(a):
> > Hi Yuri,
> >
> > thanks for the patch.
> >
> > On Wed, Aug 11, 2010 at 04:54:13PM +0400, Yuri Ludkevich wrote:
> > > Ads properly initialization to GPIO4 ( alt. fn. #1, nCS3; because GPIO4
> > > and GPIO4_2 cannot be
> > > configured as GPIO simultaneously ) so GPIO4_2 which used as irq line
> > > from UCB1400 may be
> > > detected while irq autoprobing routine.
> >
> > This looks fine to me, but Marek wanted to rework the board support in
> > order to unify the GPIO configs for better readability. Marek, is there
> > any tree which contains your changes already?
> >
> I hope there will be tomorrow ...
Yuri, could you check out Marek's tree from
git://git.kernel.org/pub/scm/linux/kernel/git/marex/pxa-linux-2.6.git work
(not that "work" ist the branch you'll need to work on).
You'll see that colibri-pxa320.c looks a lot different now, so your
patch should be a one-liner now.
Also, more testing of this code is certainly appreciated :)
Thanks,
Daniel
next prev parent reply other threads:[~2010-08-18 11:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 12:54 [PATCH] ARM: COLIBRI PXA320: fix UCB1400 irq autoprobing Yuri Ludkevich
2010-08-11 14:33 ` Daniel Mack
2010-08-11 21:26 ` Marek Vasut
2010-08-12 11:48 ` Marek Vasut
2010-08-18 11:50 ` Daniel Mack [this message]
2010-08-20 8:34 ` Yuri Ludkevich
2010-08-20 9:34 ` Marek Vasut
2010-08-20 9:50 ` Daniel Mack
2010-08-11 21:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818115008.GI17833@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.