From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: stable-review@kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk
Subject: [2/6] mm: fix missing page table unmap for stack guard page failure case
Date: Wed, 18 Aug 2010 08:01:56 -0700 [thread overview]
Message-ID: <20100818150557.276273181@clark.site> (raw)
In-Reply-To: <20100818150615.GA4752@kroah.com>
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------
From: Linus Torvalds <torvalds@linux-foundation.org>
commit 5528f9132cf65d4d892bcbc5684c61e7822b21e9 upstream.
.. which didn't show up in my tests because it's a no-op on x86-64 and
most other architectures. But we enter the function with the last-level
page table mapped, and should unmap it at exit.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
mm/memory.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -2428,8 +2428,10 @@ static int do_anonymous_page(struct mm_s
spinlock_t *ptl;
pte_t entry;
- if (check_stack_guard_page(vma, address) < 0)
+ if (check_stack_guard_page(vma, address) < 0) {
+ pte_unmap(page_table);
return VM_FAULT_SIGBUS;
+ }
/* Allocate our own private page. */
pte_unmap(page_table);
next prev parent reply other threads:[~2010-08-18 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 15:06 [0/6] 2.6.27.52 stable review [try 3] Greg KH
2010-08-18 15:01 ` [1/6] mm: keep a guard page below a grow-down stack segment Greg KH
2010-08-18 15:01 ` Greg KH [this message]
2010-08-18 15:01 ` [3/6] x86: dont send SIGBUS for kernel page faults Greg KH
2010-08-18 15:01 ` [4/6] mm: pass correct mm when growing stack Greg KH
2010-08-18 15:01 ` [5/6] mm: fix page table unmap for stack guard page properly Greg KH
2010-08-18 15:02 ` [6/6] mm: fix up some user-visible effects of the stack guard page Greg KH
2010-08-19 1:18 ` [0/6] 2.6.27.52 stable review [try 3] Gabor Z. Papp
2010-08-19 14:24 ` [stable] " Greg KH
2010-08-23 22:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818150557.276273181@clark.site \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.