From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OlkrR-000371-Qn for mharc-grub-devel@gnu.org; Wed, 18 Aug 2010 11:47:29 -0400 Received: from [140.186.70.92] (port=50485 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OlkrL-00036g-7k for grub-devel@gnu.org; Wed, 18 Aug 2010 11:47:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OlkrG-00076G-6H for grub-devel@gnu.org; Wed, 18 Aug 2010 11:47:23 -0400 Received: from hall.aurel32.net ([88.191.82.174]:36188) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OlkrG-00075D-1r for grub-devel@gnu.org; Wed, 18 Aug 2010 11:47:18 -0400 Received: from [2a01:e35:2e80:2fb0:21e:8cff:feb0:693b] (helo=volta.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Olkr6-0007iI-7o; Wed, 18 Aug 2010 17:47:08 +0200 Received: from aurel32 by volta.aurel32.net with local (Exim 4.72) (envelope-from ) id 1OlkqO-0007J2-1m; Wed, 18 Aug 2010 17:46:24 +0200 Date: Wed, 18 Aug 2010 17:46:24 +0200 From: Aurelien Jarno To: grub-devel@gnu.org Message-ID: <20100818154623.GA7883@volta.aurel32.net> References: <20100818130757.88123.80791.reportbug@kfreebsd-amd64.aurel32.net> <20100818141602.GC12396@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100818141602.GC12396@riva.ucam.org> X-Mailer: Mutt 1.5.20 (2009-06-14) User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: 593467@bugs.debian.org, Colin Watson Subject: Re: Bug#593467: grub-pc: add support for root ext2/xfs on GNU/kFreeBSD X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2010 15:47:28 -0000 On Wed, Aug 18, 2010 at 03:16:03PM +0100, Colin Watson wrote: > On Wed, Aug 18, 2010 at 03:07:57PM +0200, Aurelien Jarno wrote: > > Since GNU/kFreeBSD switch to grub as the default bootloader, it is > > almost possible to use an ext2 or xfs root filesystem. While there > > is not a lot of interest in doing that, the patch to do it is quite > > small. Could you please apply it in the next upload? > > Sending upstream first. Does this require copyright assignment? > As I have been told on IRC, XFS support is only read-only, so there is no point on adding root support for it yet. ext2 support works in read write mode, and has been tested as root. Please find an updated patch below. --- grub2-1.98+20100804.orig/util/grub.d/10_kfreebsd.in +++ grub2-1.98+20100804/util/grub.d/10_kfreebsd.in @@ -75,6 +75,14 @@ fi case "${kfreebsd_fs}" in + ext2fs) + test -e "${module_dir}/ext2fs.ko" + + printf '%s\n' "${prepare_module_dir_cache}" + cat << EOF + kfreebsd_module_elf ${module_dir_rel}/ext2fs.ko +EOF + ;; zfs) test -e "${module_dir}/opensolaris.ko" test -e "${module_dir}/zfs.ko" @@ -121,6 +129,7 @@ case ${GRUB_FS} in ufs1 | ufs2) kfreebsd_fs=ufs ;; + ext2) kfreebsd_fs=ext2fs ;; *) kfreebsd_fs=${GRUB_FS} ;; esac -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net