From: David Aguilar <davvid@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] submodule sync: Update "submodule.<name>.url"
Date: Wed, 18 Aug 2010 08:46:49 -0700 [thread overview]
Message-ID: <20100818154637.GA10028@gmail.com> (raw)
In-Reply-To: <4C6BB9E2.4060700@viscovery.net>
On Wed, Aug 18, 2010 at 12:45:54PM +0200, Johannes Sixt wrote:
> Am 8/18/2010 12:01, schrieb David Aguilar:
> > @@ -840,9 +840,10 @@ cmd_sync()
> > then
> > (
> > clear_local_git_env
> > + say "Synchronizing submodule url for '$name'"
> > + git config submodule."$name".url "$url"
>
> This git config applies to the super module, right? As such, shouldn't it
> happen before you clear_local_git_env?
Good catch, thanks. I'll resend.
>
> > cd "$path"
> > remote=$(get_default_remote)
> > - say "Synchronizing submodule url for '$name'"
> > git config remote."$remote".url "$url"
> > )
>
> -- Hannes
--
David
next prev parent reply other threads:[~2010-08-18 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 10:01 [PATCH] submodule sync: Update "submodule.<name>.url" David Aguilar
2010-08-18 10:45 ` Johannes Sixt
2010-08-18 15:46 ` David Aguilar [this message]
2010-08-18 15:58 ` [PATCH v2] " David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818154637.GA10028@gmail.com \
--to=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.