From: Borislav Petkov <bp@amd64.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Joerg Roedel <joro@8bytes.org>,
"Roedel, Joerg" <Joerg.Roedel@amd.com>,
"mingo@elte.hu" <mingo@elte.hu>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"Herrmann3, Andreas" <Andreas.Herrmann3@amd.com>,
"Seidel, Conny" <Conny.Seidel@amd.com>,
"Sarathy, Bhavna" <Bhavna.Sarathy@amd.com>,
"greg@kroah.com" <greg@kroah.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2 1/2] x86-32: Fix crashes with CPU hotplug on AMD machines
Date: Wed, 18 Aug 2010 21:09:15 +0200 [thread overview]
Message-ID: <20100818190915.GB12842@aftab> (raw)
In-Reply-To: <4C6C294D.3030404@zytor.com>
From: "H. Peter Anvin" <hpa@zytor.com>
Date: Wed, Aug 18, 2010 at 02:41:17PM -0400
> On 08/16/2010 05:38 AM, Borislav Petkov wrote:
> > #else
> > static inline void reserve_trampoline_memory(void) {};
> > +extern void __init setup_trampoline_page_table(void) {};
> > #endif /* CONFIG_X86_TRAMPOLINE */
>
> This breaks compilation in the !CONFIG_X86_TRAMPOLINE case; I presume
> you meant:
>
> static inline void setup_trampoline_page_table(void) {}
>
> ... here too?
>
> (No semicolon after a function body!)
Yeah, thanks for catching that - this should be a static inline stub in
the !CONFIG_X86_TRAMPOLINE case.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-08-18 19:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 16:45 [PATCH 0/2] Fix 32-bit CPU hotplug issue on AMD Borislav Petkov
2010-08-04 16:45 ` [PATCH 1/2] x86-32: Fix crashes with CPU hotplug on AMD machines Borislav Petkov
2010-08-04 23:05 ` H. Peter Anvin
2010-08-05 4:48 ` Borislav Petkov
2010-08-05 7:45 ` Roedel, Joerg
2010-08-05 14:14 ` H. Peter Anvin
2010-08-12 14:41 ` Joerg Roedel
2010-08-12 15:34 ` H. Peter Anvin
2010-08-12 15:47 ` Borislav Petkov
2010-08-12 15:47 ` H. Peter Anvin
2010-08-12 17:38 ` Borislav Petkov
2010-08-24 7:33 ` Initial working version (Re: [PATCH 1/2] x86-32: Fix crashes with CPU hotplug on AMD machines) Borislav Petkov
2010-08-29 20:32 ` [PATCH] x86-32, mm: Add an initial page table for core bootstrapping Borislav Petkov
2010-09-02 9:10 ` [PATCH -v1.1] " Borislav Petkov
2010-08-12 17:06 ` [PATCH 1/2] x86-32: Fix crashes with CPU hotplug on AMD machines Joerg Roedel
2010-08-12 19:01 ` H. Peter Anvin
2010-08-12 19:04 ` Joerg Roedel
2010-08-13 12:35 ` Borislav Petkov
2010-08-16 12:19 ` Borislav Petkov
2010-08-16 12:38 ` [PATCH -v2 " Borislav Petkov
2010-08-18 18:41 ` H. Peter Anvin
2010-08-18 19:09 ` Borislav Petkov [this message]
2010-08-18 20:55 ` [tip:x86/urgent] x86-32: Fix dummy trampoline-related inline stubs tip-bot for H. Peter Anvin
2010-08-18 20:55 ` [tip:x86/urgent] x86-32: Separate 1:1 pagetables from swapper_pg_dir tip-bot for Joerg Roedel
2010-08-16 12:39 ` [PATCH -v2 2/2] x86, cpu hotplug: Fix cpu bringup concurrency issue Borislav Petkov
2010-08-18 19:03 ` H. Peter Anvin
2010-08-18 19:28 ` Borislav Petkov
2010-08-18 20:04 ` H. Peter Anvin
2010-08-19 18:10 ` [PATCH -v2.1 " Borislav Petkov
2010-08-19 22:58 ` [tip:x86/urgent] x86, hotplug: Serialize CPU hotplug to avoid bringup concurrency issues tip-bot for Borislav Petkov
2010-08-04 16:45 ` [PATCH 2/2] x86, cpu hotplug: Fix cpu bringup concurrency issue Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818190915.GB12842@aftab \
--to=bp@amd64.org \
--cc=Andreas.Herrmann3@amd.com \
--cc=Bhavna.Sarathy@amd.com \
--cc=Conny.Seidel@amd.com \
--cc=Joerg.Roedel@amd.com \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.