From: Dave Jones <davej@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: apw@canonical.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: add memset checks to checkpatch.pl
Date: Wed, 18 Aug 2010 18:17:22 -0400 [thread overview]
Message-ID: <20100818221721.GA2667@redhat.com> (raw)
In-Reply-To: <1282168679.6724.174.camel@Joe-Laptop>
On Wed, Aug 18, 2010 at 02:57:59PM -0700, Joe Perches wrote:
> > I'm all for improving my shoddy perl where possible, but this doesn't seem to actually
> > catch any of the test cases I wrote. (it's also missing a } )
>
> I intend never to be a perl monk.
>
> I notice the missing { before the elsif after I sent it.
> Oh well.
>
> I just typed it in the emailer, so it's not tested at all.
> Also it's missing a $ after 1 in the second $memset_size test.
still didn't catch anything for me.
> What are your test cases anyway?
memset(foo, 0, 10);
memset(foo, 10, 0);
memset(foo, 1, 10);
memset(foo, 10, 1);
> Likely $Lval isn't matching things like
> sizeof(*foo) so this isn't checked:
>
> memset(foo, bar, sizeof(*foo));
I chose to just ignore any non integer arguments to keep things simple.
Dave
next prev parent reply other threads:[~2010-08-18 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 20:40 add memset checks to checkpatch.pl Dave Jones
2010-08-18 21:32 ` Joe Perches
2010-08-18 21:48 ` Dave Jones
2010-08-18 21:57 ` Joe Perches
2010-08-18 22:17 ` Dave Jones [this message]
2010-08-18 23:38 ` Joe Perches
2010-09-02 10:52 ` Andy Whitcroft
2010-09-02 13:17 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818221721.GA2667@redhat.com \
--to=davej@redhat.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.