From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Nohez <nohez@cmie.com>, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: kernel bug in xfs_lrw.c (centos v5.5, directio, aio)
Date: Thu, 19 Aug 2010 11:50:29 +1000 [thread overview]
Message-ID: <20100819015029.GQ7362@dastard> (raw)
In-Reply-To: <040DE437-1D0C-45F1-8CC7-CD11D49B6E53@sandeen.net>
On Wed, Aug 18, 2010 at 08:38:33PM -0500, Eric Sandeen wrote:
> On Aug 18, 2010, at 8:34 PM, Dave Chinner <david@fromorbit.com> wrote:
>
> > On Wed, Aug 18, 2010 at 07:47:09PM -0500, Eric Sandeen wrote:
> >> On Aug 18, 2010, at 6:43 AM, Dave Chinner <david@fromorbit.com> wrote:
> >>
> >>> On Tue, Aug 17, 2010 at 07:12:12PM +0530, Nohez wrote:
> >>>>
> >>>> Hi,
> >>>>
> >>>> I had a kernel bug today when running xfs on CentOS v5.5. I moved to
> >>>> xfs from ext3 today.
> >>>>
> >>>> The only application accessing the xfs filesystem is Sybase ASE v15.x.
> >>>> Database has been configured to use directio with native kernel
> >>>> asynchronous disk i/o enabled.
> >>>
> >>> The warning is being issued because the application is mixing
> >>> buffered IO with direct IO on the same file. i.e. data corruption
> >>> waiting to happen. This is an application bug - the responsibility
> >>> for ensuring data coherency and integrity is assumed by the
> >>> application issuing the direct IO.
> >>>
> >> You know... A clearer kernel message might help a lot here...
> >
> > Yeah, probably would given we've had more reports of this in the
> > last month or two than we've had in the last five years. What sort
> > of text do you think we should add? I'd argue on the scary side,
> > say:
> >
> > "XFS: filesystem 〈blah>: detected potential data corruption issue
> > caused by application(s) mixing concurrent buffered and direct IO to
> > the same inode. Inode #12345, pid 6789. Please report this issue
> > to your application vendor."
> >
> > What do you think?
> >
> Plenty verbose, might want to limit/throttle it, but sure.
Rate limiting it is a good idea, anyway. How about this:
"XFS: <dev>: inode <#>: pid <#> <name>: detected potential data
corruption issue due to concurrent buffered and direct IO to the
same inode. Please report this issue to your application vendor."
> Maybe include current->comm?
Yes, I thought about that but hadn't gone looking to find out how
easy it was to get the process name.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-08-19 1:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 13:42 kernel bug in xfs_lrw.c (centos v5.5, directio, aio) Nohez
2010-08-18 11:43 ` Dave Chinner
2010-08-18 14:51 ` Nohez
2010-08-18 15:55 ` Dave Chinner
2010-08-19 0:47 ` Eric Sandeen
2010-08-19 1:34 ` Dave Chinner
2010-08-19 1:38 ` Eric Sandeen
2010-08-19 1:50 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819015029.GQ7362@dastard \
--to=david@fromorbit.com \
--cc=nohez@cmie.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.