All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux-kernel@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>,
	Randy Dunlap <rdunlap@xenotime.net>,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH] Documentation: kernel-locking: mutex_trylock cannot be used in interrupt context
Date: Thu, 19 Aug 2010 10:22:42 +0930	[thread overview]
Message-ID: <201008191022.43524.rusty@rustcorp.com.au> (raw)
In-Reply-To: <tkrat.12a11fb05527c6ed@s5r6.in-berlin.de>

On Thu, 19 Aug 2010 07:38:15 am Stefan Richter wrote:
> Chapter 6 is right about mutex_trylock, but chapter 10 wasn't.
> This error was introduced during semaphore-to-mutex conversion of the
> Unreliable guide. :-)
> 
> If user context which performs mutex_lock() or mutex_trylock() is
> preempted by interrupt context which performs mutex_trylock() on the
> same mutex instance, a deadlock occurs.  This is because these functions
> do not disable local IRQs when they operate on mutex->wait_lock.

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

I'm assuming Andrew Morton or Randy Dunlap will pick this up...

Thanks!
Rusty.

      reply	other threads:[~2010-08-19  0:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18 22:08 [PATCH] Documentation: kernel-locking: mutex_trylock cannot be used in interrupt context Stefan Richter
2010-08-19  0:52 ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008191022.43524.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=rdunlap@xenotime.net \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.