From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] libxc: make unlock_page return error Date: Thu, 19 Aug 2010 10:44:46 +0200 Message-ID: <201008191044.46554.Christoph.Egger@amd.com> References: <201008181642.10467.Christoph.Egger@amd.com> <19564.1236.264564.401870@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19564.1236.264564.401870@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Wednesday 18 August 2010 18:05:40 Ian Jackson wrote: > Christoph Egger writes ("[Xen-devel] [PATCH] libxc: make unlock_page return error"): > > As a result of debugging 'xend segfaults when starting', > > the attached patch makes unlock_pages return an error. > > I'm not opposed to this general idea, but: you change unlock_pages to > return an int but you don't seem to change any of its callers. That's right. I leave this todo item to someone else. > What is the point ? In this shape it helps debugging problems like I do with Ian Campell. It makes it easy to just add a debug output to print the error code. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632