From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC/multi-component: fix au1x platform Date: Thu, 19 Aug 2010 15:06:50 +0100 Message-ID: <20100819140649.GA29395@opensource.wolfsonmicro.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org Cc: alsa-devel@vger.kernel.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org On Thu, Aug 19, 2010 at 03:21:35PM +0200, Manuel Lauss wrote: > Attached is a patch which fixes the Alchemy (au1x) audio platform > in your "topic/multi-component" branch. I would provide more detailed review but you've attached your patch as a base64 encoded attachment rather than including it inline so my MUA hasn't quoted it. As far as your comments about multiple cards go this should now be supported, though the fact that you're modifying the static data for the DAI means that the aux1x drivers probably don't support this or only support it in a limited fashion. Your kobject_name() stuff looks pretty fishy - is there some reason for not using dev_name()?