All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
Cc: meego-dev@meego.com, LKML <linux-kernel@vger.kernel.org>,
	yong.y.wang@intel.com, qi.wang@intel.com,
	andrew.chih.howe.khor@intel.com, arjan@linux.intel.com,
	alan@linux.intel.com, margie.foster@intel.com
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_PHUB driver to 2.6.35
Date: Thu, 19 Aug 2010 08:17:12 -0700	[thread overview]
Message-ID: <20100819151712.GC2562@suse.de> (raw)
In-Reply-To: <000401cb3f67$9936adf0$66f8800a@maildom.okisemi.com>

On Thu, Aug 19, 2010 at 03:27:23PM +0900, Masayuki Ohtake wrote:
> Hi Greg,
> 
> Thank you for your comments.
> > > +#define MODULE_NAME "pch_phub"
> >
> > This isn't needed, right?  The kernel provides this to you in the build
> > service automatically.
> 
> I can't understand above enough.
> Is the above mean  like below ?
> 
> * Delete the following line.
> > > +#define MODULE_NAME "pch_phub"
> 
>  * Modify the following line(Use "pch_phub" directly)
> > > + ret = pci_request_regions(pdev, "pch_phub");

No, use the variable that the build system provides to you,
KBUILD_MODNAME

thanks,

greg k-h

  reply	other threads:[~2010-08-19 15:22 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18  9:10 [MeeGo-Dev][PATCH] Topcliff: Update PCH_PHUB driver to 2.6.35 Masayuki Ohtak
2010-08-18 13:14 ` Greg KH
2010-08-19  6:27   ` Masayuki Ohtake
2010-08-19 15:17     ` Greg KH [this message]
2010-08-20  6:53       ` Masayuki Ohtake
2010-08-19 12:25   ` Masayuki Ohtake
2010-08-19 15:22     ` Greg KH
2010-08-23 12:30       ` Masayuki Ohtake
2010-08-23 15:34         ` Greg KH
2010-08-24  0:02           ` Masayuki Ohtake
2010-08-24  6:46   ` Masayuki Ohtake
  -- strict thread matches above, loose matches on Subject: below --
2010-08-24  6:47 Masayuki Ohtak
2010-08-24 13:22 ` Greg KH
2010-08-25 10:16 Masayuki Ohtak
2010-08-25 12:05 Masayuki Ohtak
2010-09-01 12:16 Masayuki Ohtak
2010-09-01 23:09 ` Greg KH
2010-09-01 23:58   ` Masayuki Ohtake
2010-09-02  0:59     ` Greg KH
2010-09-02  1:02 ` Greg KH
2010-09-02  2:36   ` Masayuki Ohtake
2010-09-02  3:22     ` Greg KH
2010-09-02  3:29       ` Wang, Qi
2010-09-02  6:44         ` Masayuki Ohtake
2010-09-02 13:19           ` Greg KH
2010-09-03  0:22             ` Masayuki Ohtake
2010-09-03  2:14               ` Greg KH
2010-09-03  1:13             ` Wang, Qi
2010-09-02  6:38       ` Masayuki Ohtake
2010-09-02 13:18         ` Greg KH
2010-09-03  0:17           ` Masayuki Ohtake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100819151712.GC2562@suse.de \
    --to=gregkh@suse.de \
    --cc=alan@linux.intel.com \
    --cc=andrew.chih.howe.khor@intel.com \
    --cc=arjan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=margie.foster@intel.com \
    --cc=masa-korg@dsn.okisemi.com \
    --cc=meego-dev@meego.com \
    --cc=qi.wang@intel.com \
    --cc=yong.y.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.