From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brade Subject: Re: Patch fixing vlan handling when network-bridge scriptis used Date: Thu, 19 Aug 2010 17:59:29 +0200 Message-ID: <201008191759.39253.brade@kde.org> References: <232221223.568081282131308987.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> <19564.1064.460057.337893@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0135239379==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --===============0135239379== Content-Type: multipart/signed; boundary="nextPart51304639.CLTVsiIGpd"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart51304639.CLTVsiIGpd Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Thursday 19 August 2010 06:20:47 James Harper wrote: > > Miroslav Rezanina writes ("[Xen-devel] Patch fixing vlan handling when > >=20 > > network-bridge script is used"): > > > We had problem using tagged vlans inside domU. Testing shows that > > > this is caused by changing network interfaces in network-bridge > > > script. Following patch should allow to use vlans in guest. > >=20 > > Thanks for reporting this. > >=20 > > This is just another way in which the network-bridge approach, of > > trying to transfer all the details from one interface to another, > > won't work well. > >=20 > > I think you would be much better served if you just used your > > operating system's features (/etc/network/interfaces on Debian) to set > > up the bridge and call it xenbr0, and disabled network-bridge > > entirely. > >=20 > > Rather than apply your patch, I would prefer to change network-bridge > > so that it explicitly fails when vlans are detected and tells you to > > do it the other way. > >=20 > > Anyone else have an opinion / >=20 > I always set up networking in /etc/network/interfaces. I think that xend > doing it for you is nice but it breaks so easily that I wonder if it's > worth it at all. IMO, the default should be that xend doesn't touch the > bridge at all, but leave the option to do so in the config but commented > out. >=20 > Of course, you don't hear from the people that are all using it with no > problem at all... Well, I did have a few problems with the network-script, too, and then deci= ded=20 to drop it and do it all in network/interfaces. I didn't report it because = the=20 main problem for me was initialization order and there is nothing that I fo= und=20 that could be done to fix that script - when xend starts it's already too l= ate. But I had to add the "ethtool -K $vif tx off" to vif-bridge to fix the chec= ksums=20 error. Maybe this could be added by default with a check for ethtool? cheers, =2D-=20 Michael Brade; KDE Developer |-mail: echo brade !#|tr -d "c oh"|s\e\d 's/e/\@/2;s/$/.org/;s/bra/k/2' =B0--web: http://www.behindkde.org/people/michaelb/ KDE 4: Beyond Your Expectations --nextPart51304639.CLTVsiIGpd Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEABECAAYFAkxtVOEACgkQdK2tAWD5bo0MDwCeNyCSuiNJ977eNej8AD90Teyt k9wAoObsndubYcZzfnLVFni8p7yDVO46 =GbjQ -----END PGP SIGNATURE----- --nextPart51304639.CLTVsiIGpd-- --===============0135239379== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0135239379==--