From: Andreas Gruenbacher <agruen@suse.de>
To: Tvrtko Ursulin <tvrtko.ursulin@sophos.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
Eric Paris <eparis@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: struct fanotify_event_metadata
Date: Thu, 19 Aug 2010 18:07:01 +0200 [thread overview]
Message-ID: <201008191807.02031.agruen@suse.de> (raw)
In-Reply-To: <201008191644.29299.tvrtko.ursulin@sophos.com>
On Thursday 19 August 2010 17:44:29 Tvrtko Ursulin wrote:
> On Saturday 14 Aug 2010 18:44:38 Andreas Schwab wrote:
> > The pid field of struct fanotify_event_metadata has 64 bits which looks
> > excessive. Wouldn't it make sense to make it 32 bits and swap it with
> > the mask field? That would avoid the unaligned mask field, and remove
> > the need for the packed attribute.
>
> No one seems to have picked up on this what I thought was an obvious good
> idea.
Yes, the pid field should be shrunk; it is a 32-bit value in user-space even
on 64-bit platforms. I also don't see that we'll ever need a 64-bit mask
actually.
Andreas
next prev parent reply other threads:[~2010-08-19 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-14 17:44 struct fanotify_event_metadata Andreas Schwab
2010-08-19 15:44 ` Tvrtko Ursulin
2010-08-19 16:07 ` Andreas Gruenbacher [this message]
2010-08-19 16:35 ` Tvrtko Ursulin
2010-08-19 17:53 ` Eric Paris
2010-08-20 9:02 ` Tvrtko Ursulin
2010-08-20 9:16 ` Andreas Schwab
2010-08-20 9:23 ` Tvrtko Ursulin
2010-08-20 13:13 ` Eric Paris
2010-08-20 13:27 ` Andreas Schwab
2010-08-20 15:19 ` Eric Paris
2010-08-20 17:47 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008191807.02031.agruen@suse.de \
--to=agruen@suse.de \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@linux-m68k.org \
--cc=tvrtko.ursulin@sophos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.