From: David Miller <davem@davemloft.net>
To: tj@kernel.org
Cc: linux-ide@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH] ide: remove unnecessary blk_queue_flushing() test in do_ide_request()
Date: Fri, 20 Aug 2010 10:31:45 -0700 (PDT) [thread overview]
Message-ID: <20100820.103145.57462467.davem@davemloft.net> (raw)
In-Reply-To: <4C6D3329.7030901@kernel.org>
From: Tejun Heo <tj@kernel.org>
Date: Thu, 19 Aug 2010 15:35:37 +0200
> Unplugging from a request function doesn't really help much (it's
> already in the request_fn) and soon block layer will be updated to mix
> barrier sequence with other commands, so there's no need to treat
> queue flushing any differently.
>
> ide was the only user of blk_queue_flushing(). Remove it.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Christoph Hellwig <hch@lst.de>
> ---
> David, can I route this patch through block tree with other barrier
> changes?
Sure:
Acked-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2010-08-20 17:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 13:35 [PATCH] ide: remove unnecessary blk_queue_flushing() test in do_ide_request() Tejun Heo
2010-08-20 17:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820.103145.57462467.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.