From: Tony Lindgren <tony@atomide.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: "Krogerus Heikki (EXT-Teleca/Helsinki)"
<ext-heikki.krogerus@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"Balbi Felipe (Nokia-MS/Helsinki)" <felipe.balbi@nokia.com>,
"Palande Ameya (Nokia-MS/Helsinki)" <ameya.palande@nokia.com>,
"Lehtonen Markus (Nokia-MS/Helsinki)" <markus.lehtonen@nokia.com>,
Roger Quadros <roger.quadros@nokia.com>
Subject: Re: [PATCHv2 2/2] omap: rx51: add support for USB chargers
Date: Fri, 20 Aug 2010 10:25:26 +0300 [thread overview]
Message-ID: <20100820072525.GJ25742@atomide.com> (raw)
In-Reply-To: <4C6D3EED.7040703@nokia.com>
Hi,
* Roger Quadros <roger.quadros@nokia.com> [100819 17:17]:
> On 08/19/2010 04:09 PM, Krogerus Heikki (EXT-Teleca/Helsinki) wrote:
> >On Thu, Aug 19, 2010 at 02:40:42PM +0200, ext Anton Vorontsov wrote:
> >>On Thu, Aug 19, 2010 at 03:09:37PM +0300, Krogerus Heikki (EXT-Teleca/Helsinki) wrote:
> >>>@@ -909,5 +913,6 @@ void __init rx51_peripherals_init(void)
> >>> spi_register_board_info(rx51_peripherals_spi_board_info,
> >>> ARRAY_SIZE(rx51_peripherals_spi_board_info));
> >>> omap2_hsmmc_init(mmc);
> >>>+ platform_device_register(&rx51_charger_device);
> >>
> >>Maybe
> >>
> >> platform_device_register_simple("isp1704_charger", -1, NULL, 0);
> >
> >I guess it's enough in this case. Ameya, Roger, any objections?
> >
> I'm fine with the current approach. No need to re-spin.
Just checking.. Anton, can you please queue up this 2/2 patch too to
keep them together? Here's my ack:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2010-08-20 7:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 12:09 [PATCHv2 0/2] add isp1704 power supply driver Krogerus Heikki (EXT-Teleca/Helsinki)
2010-08-19 12:09 ` [PATCHv2 1/2] power_supply: add isp1704 charger detection driver Krogerus Heikki (EXT-Teleca/Helsinki)
2010-08-19 12:36 ` Anton Vorontsov
2010-08-19 12:09 ` [PATCHv2 2/2] omap: rx51: add support for USB chargers Krogerus Heikki (EXT-Teleca/Helsinki)
2010-08-19 12:40 ` Anton Vorontsov
2010-08-19 13:09 ` Heikki Krogerus
2010-08-19 14:25 ` Roger Quadros
2010-08-20 7:25 ` Tony Lindgren [this message]
2010-08-20 16:24 ` Anton Vorontsov
2010-08-20 8:41 ` Ameya Palande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820072525.GJ25742@atomide.com \
--to=tony@atomide.com \
--cc=ameya.palande@nokia.com \
--cc=cbouatmailru@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ext-heikki.krogerus@nokia.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=markus.lehtonen@nokia.com \
--cc=roger.quadros@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.