From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andi Kleen <andi@firstfloor.org>
Cc: Bernd Petrovitsch <bernd@sysprog.at>,
Namhyung Kim <namhyung@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] introduce ptr_diff()
Date: Fri, 20 Aug 2010 13:12:39 +0100 [thread overview]
Message-ID: <20100820121239.GT31363@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100819125957.GB6729@basil.fritz.box>
On Thu, Aug 19, 2010 at 02:59:57PM +0200, Andi Kleen wrote:
> > If so, the warning seems valid as sizeof(struct page) is probably not
> > (always) a power of 2. On a native build on x86_64 it is 56 bytes
> > hereover.
> > Hmm ....
>
>
> gcc just generats a mull with inverted value. mull is cheap on any
> reasonable CPU.
Depends on gcc version.
> Please fix sparse.
Frankly, I'd rather stop crapping -Wall into its arguments; there's
a reason why that check is optional and it's *not* defaulting to
on in sparse.
next prev parent reply other threads:[~2010-08-20 12:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 11:37 [RFC][PATCH] introduce ptr_diff() Namhyung Kim
2010-08-19 11:57 ` Bernd Petrovitsch
2010-08-19 12:03 ` David Howells
2010-08-19 16:18 ` Måns Rullgård
2010-08-19 12:23 ` Andi Kleen
2010-08-19 12:40 ` Matthew Wilcox
2010-08-19 12:58 ` Andi Kleen
2010-08-19 12:48 ` Bernd Petrovitsch
2010-08-19 12:59 ` Andi Kleen
2010-08-19 13:05 ` Bernd Petrovitsch
2010-08-19 13:39 ` Andi Kleen
2010-08-20 12:12 ` Al Viro [this message]
2010-08-19 15:53 ` Namhyung Kim
2010-08-19 16:04 ` Bernd Petrovitsch
2010-08-19 16:12 ` Namhyung Kim
2010-08-20 12:07 ` Al Viro
2010-08-20 12:49 ` Matthew Wilcox
2010-08-20 12:57 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820121239.GT31363@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=bernd@sysprog.at \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.