All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tabi Timur-B04825 <B04825@freescale.com>
Cc: alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH] asoc/multi-component: mpc8610: replace of_device with platform_device
Date: Fri, 20 Aug 2010 13:46:54 +0100	[thread overview]
Message-ID: <20100820124654.GA18845@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1E324AB3-D941-4FB8-896E-97227A0CBCE7@freescale.com>

On Fri, Aug 20, 2010 at 07:43:57AM -0500, Tabi Timur-B04825 wrote:
> I based it off the for-2.6.37 branch, so it has to apply as is.  Can
> you tell me where the conflict is?

This is the result of an attempt to apply with a 3 way merge:

diff --cc sound/soc/fsl/fsl_dma.c
index 5a6f56d,cb78698..0000000
--- a/sound/soc/fsl/fsl_dma.c
+++ b/sound/soc/fsl/fsl_dma.c
@@@ -876,9 -892,10 +877,9 @@@ static int __devinit fsl_soc_dma_probe(
  				       const struct of_device_id *match)
   {
  	struct dma_object *dma;
- 	struct device_node *np = of_dev->dev.of_node;
+ 	struct device_node *np = pdev->dev.of_node;
  	struct device_node *ssi_np;
  	struct resource res;
 -	const uint32_t *iprop;
  	int ret;
  
  	/* Find the SSI node that points to us. */
@@@ -889,15 -906,17 +890,26 @@@
  	}
  
  	ret = of_address_to_resource(ssi_np, 0, &res);
 +	of_node_put(ssi_np);
  	if (ret) {
++<<<<<<< HEAD
 +		dev_err(&of_dev->dev, "could not determine device resources\n");
++=======
+ 		dev_err(&pdev->dev, "could not determine resources for %s\n",
+ 			ssi_np->full_name);
+ 		of_node_put(ssi_np);
++>>>>>>> asoc/multi-component: mpc8610: replace of_device with platform_device
  		return ret;
  	}
  
  	dma = kzalloc(sizeof(*dma) + strlen(np->full_name), GFP_KERNEL);
  	if (!dma) {
++<<<<<<< HEAD
 +		dev_err(&of_dev->dev, "could not allocate dma object\n");
++=======
+ 		dev_err(&pdev->dev, "could not allocate dma object\n");
+ 		of_node_put(ssi_np);
++>>>>>>> asoc/multi-component: mpc8610: replace of_device with platform_device
  		return -ENOMEM;
  	}
  
@@@ -910,9 -929,18 +922,22 @@@
  	dma->ssi_stx_phys = res.start + offsetof(struct ccsr_ssi, stx0);
  	dma->ssi_srx_phys = res.start + offsetof(struct ccsr_ssi, srx0);
  
++<<<<<<< HEAD
 +	ret = snd_soc_register_platform(&of_dev->dev, &dma->dai);
++=======
+ 	iprop = of_get_property(ssi_np, "fsl,fifo-depth", NULL);
+ 	if (iprop)
+ 		dma->ssi_fifo_depth = *iprop;
+ 	else
+                 /* Older 8610 DTs didn't have the fifo-depth property */
+ 		dma->ssi_fifo_depth = 8;
+ 
+ 	of_node_put(ssi_np);
+ 
+ 	ret = snd_soc_register_platform(&pdev->dev, &dma->dai);
++>>>>>>> asoc/multi-component: mpc8610: replace of_device with platform_device
  	if (ret) {
- 		dev_err(&of_dev->dev, "could not register platform\n");
+ 		dev_err(&pdev->dev, "could not register platform\n");
  		kfree(dma);
  		return ret;
  	}

  reply	other threads:[~2010-08-20 12:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19 20:26 [PATCH] asoc/multi-component: mpc8610: replace of_device with platform_device Timur Tabi
2010-08-20  9:28 ` Liam Girdwood
2010-08-20  9:41 ` Mark Brown
2010-08-20 12:43   ` Tabi Timur-B04825
2010-08-20 12:46     ` Mark Brown [this message]
2010-08-20 15:49   ` Timur Tabi
2010-08-20 16:10     ` Liam Girdwood
2010-08-20 16:21       ` Mark Brown
2010-08-20 17:44         ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100820124654.GA18845@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=B04825@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.