From: Samuel Ortiz <sameo@linux.intel.com>
To: Mattias Wallin <mattias.wallin@stericsson.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] MFD: Align ab8500 with the abx500 interface
Date: Fri, 20 Aug 2010 23:52:07 +0200 [thread overview]
Message-ID: <20100820215206.GI3650@sortiz-mobl> (raw)
In-Reply-To: <1282037077-29255-1-git-send-email-mattias.wallin@stericsson.com>
Hi Mattias,
On Tue, Aug 17, 2010 at 11:24:37AM +0200, Mattias Wallin wrote:
> This patch makes the ab8500 mixed signal chip expose the same
> interface for register access as the ab3100, ab3550 and ab5500 chip.
> The ab8500_read() and ab8500_write() is removed and replaced with
> abx500_get_register_interruptible() and
> abx500_set_register_interruptible().
Thanks for the patch, but I'd prefer to see it split into 3 separate ones, for
mfd, rtc and regulator. And then have the relevant maintaines cc'ed with those
patches.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-08-20 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 9:24 [PATCH 1/2] MFD: Align ab8500 with the abx500 interface Mattias Wallin
2010-08-20 21:52 ` Samuel Ortiz [this message]
2010-08-21 9:14 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820215206.GI3650@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mattias.wallin@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.