Re: [PATCH] MFD: LP3974 PMIC support

[Samuel Ortiz <sameo@linux.intel.com>]

Hi Kyungmin,

On Thu, Aug 19, 2010 at 02:08:39PM +0900, Kyungmin Park wrote:
> Any comments? I hope it's included the 2.6.36 if possible.
It hopefully will be. I received the patch after the merge window opened
though.
Some comments on your patch:

> > +config MFD_LP3974
> > +       bool "National Semiconductor LP3974 PMIC Support"
> > +       depends on I2C=y
> > +       select MFD_CORE
> > +       select MFD_MAX8998
> > +       help
> > +         Say yes here to support for National Semiconductor LP3974. This is
> > +         a Power Management IC. This driver provies common support for
> > +         accessing the device, additional drivers must be enabled in order
> > +         to use the functionality of the device.
> > +         Note that it has same functionality with max8998.
As Jonathan mentioned, there really is no need for a Kconfig symbol. Just
change the existing Kconfig comments to add your device there.


> >  config MFD_WM8400
> >        tristate "Support Wolfson Microelectronics WM8400"
> >        select MFD_CORE
> > diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
> > index 0d68de2..cea9f48 100644
> > --- a/drivers/mfd/max8998.c
> > +++ b/drivers/mfd/max8998.c
> > @@ -30,6 +30,11 @@
> >  #include <linux/mfd/max8998.h>
> >  #include <linux/mfd/max8998-private.h>
> >
> > +enum max8998_type {
> > +       TYPE_MAX8998,
> > +       TYPE_LP3974,
> > +};
Not used, so please remove that.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/